Skip to content

chore: Set accepted condition as true when failed to resolve backends #6081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhaohuabing merged 7 commits into from
Jun 5, 2025
Merged

chore: Set accepted condition as true when failed to resolve backends #6081

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
618f8be
Set accepted condition as true when failed to resolve backends
zhaohuabing May 15, 2025
b0a8de8
address comment
zhaohuabing Jun 4, 2025
ecdf5ba
trigger build
zhaohuabing Jun 4, 2025
256c23d
trigger build
zhaohuabing Jun 4, 2025
41b0053
Merge branch 'main' into fix-5850
zhaohuabing Jun 4, 2025
9ba30fb
fix gen
zhaohuabing Jun 4, 2025
e702401
fix gen
zhaohuabing Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions internal/gatewayapi/route.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1113,16 +1113,6 @@ func (t *Translator) processUDPRouteParentRefs(udpRoute *UDPRouteContext, resour
metav1.ConditionFalse,
resolveErrs.Reason(),
resolveErrs.Error())

// TODO: zhaohuabing should we set the accepted condition to false here?
status.SetRouteStatusCondition(routeStatus,
parentRef.routeParentStatusIdx,
udpRoute.GetGeneration(),
gwapiv1.RouteConditionAccepted,
metav1.ConditionFalse,
"Failed to process the settings associated with the UDP route.",
resolveErrs.Error(),
)
} else {
status.SetRouteStatusCondition(routeStatus,
parentRef.routeParentStatusIdx,
Expand Down
10 changes: 7 additions & 3 deletions ...ewayapi/testdata/gateway-with-listener-with-udproute-with-mismatch-port-protocol.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,9 @@ udpRoutes:
parents:
- conditions:
- lastTransitionTime: null
message: UDP Port 8080 not found on Service default/service-1
reason: Failed to process the settings associated with the UDP route.
status: "False"
message: Route is accepted

@zirain zirain Jun 5, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, the prev one is better for debuging.

@zhaohuabing zhaohuabing Jun 5, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still get the UDP Port 8080 not found on Service default/service-1 message in the ResolvedRefs condition.

reason: Accepted
status: "True"
type: Accepted
- lastTransitionTime: null
message: UDP Port 8080 not found on Service default/service-1
Expand All @@ -100,3 +100,7 @@ xdsIR:
- address: 0.0.0.0
name: envoy-gateway/gateway-1/udp
port: 10162
route:
destination:
name: udproute/default/udproute-1/rule/-1
name: udproute/default/udproute-1

@zhaohuabing zhaohuabing May 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For HTTPRoute, we generate a route with a 500 direct response for routes with failed backends. However, there's no similar mechanism for UDP/TCP/TLS Route.

@arkodg arkodg May 23, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you plug this IR into xds translator test so we can see what this inconsistent state looks like ?

@zhaohuabing zhaohuabing Jun 4, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test in the xDS - it'll generate a cluster without endpoints.