chore: Set accepted condition as true when failed to resolve backends#6081
chore: Set accepted condition as true when failed to resolve backends#6081zhaohuabing merged 7 commits intoenvoyproxy:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6081 +/- ##
==========================================
+ Coverage 70.46% 70.50% +0.03%
==========================================
Files 220 220
Lines 36625 36615 -10
==========================================
+ Hits 25809 25815 +6
+ Misses 9286 9274 -12
+ Partials 1530 1526 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhaohuabing
force-pushed
the
fix-5850
branch
2 times, most recently
from
71bc86c to
ea7130e
Compare
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
| route: | ||
| destination: | ||
| name: udproute/default/udproute-1/rule/-1 | ||
| name: udproute/default/udproute-1 |
There was a problem hiding this comment.
For HTTPRoute, we generate a route with a 500 direct response for routes with failed backends. However, there's no similar mechanism for UDP/TCP/TLS Route.
There was a problem hiding this comment.
can you plug this IR into xds translator test so we can see what this inconsistent state looks like ?
There was a problem hiding this comment.
Add a test in the xDS - it'll generate a cluster without endpoints.
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
| message: UDP Port 8080 not found on Service default/service-1 | ||
| reason: Failed to process the settings associated with the UDP route. | ||
| status: "False" | ||
| message: Route is accepted |
There was a problem hiding this comment.
TBH, the prev one is better for debuging.
There was a problem hiding this comment.
We still get the UDP Port 8080 not found on Service default/service-1 message in the ResolvedRefs condition.
3 participants
According to Gateway API specs, Backend resolve failure should not affect the Accepted condition.
This also makes the Status handling for UDPRoutes consistent with how it's done for HTTPRoutes and TCPRoutes.
Fixes #5850