Skip to content

use sds to fetch the client certificate for envoy-ratelimit TLS connections#5988

Merged
zirain merged 10 commits into
envoyproxy:mainfrom
zhaohuabing:fix-gatewaynamespace-ratelimit
May 21, 2025
Merged

use sds to fetch the client certificate for envoy-ratelimit TLS connections#5988
zirain merged 10 commits into
envoyproxy:mainfrom
zhaohuabing:fix-gatewaynamespace-ratelimit

address comment

0e27f32
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded May 21, 2025 in 0s

70.47% (target 60.00%)

View this Pull Request on Codecov

70.47% (target 60.00%)

Details

Codecov Report

Attention: Patch coverage is 82.05128% with 28 lines in your changes missing coverage. Please review.

Project coverage is 70.47%. Comparing base (452651b) to head (0e27f32).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/xds/translator/globalresources.go 80.00% 11 Missing and 5 partials ⚠️
internal/provider/kubernetes/controller.go 76.00% 6 Missing ⚠️
internal/provider/kubernetes/predicates.go 66.66% 2 Missing and 1 partial ⚠️
internal/xds/translator/translator.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5988      +/-   ##
==========================================
- Coverage   70.50%   70.47%   -0.04%     
==========================================
  Files         217      219       +2     
  Lines       36191    36315     +124     
==========================================
+ Hits        25517    25593      +76     
- Misses       9160     9199      +39     
- Partials     1514     1523       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov