feature(translator): cluster and endpoint xds metadata#5875
feature(translator): cluster and endpoint xds metadata#5875arkodg merged 11 commits intoenvoyproxy:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5875 +/- ##
==========================================
+ Coverage 70.48% 70.52% +0.04%
==========================================
Files 219 219
Lines 36318 36347 +29
==========================================
+ Hits 25597 25634 +37
+ Misses 9197 9192 -5
+ Partials 1524 1521 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e5aae01 to
19f47ee
Compare
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
768debb to
ccde906
Compare
internal/cmd/egctl/testdata/translate/out/default-resources.all.yaml
Outdated
Show resolved
Hide resolved
|
thanks @guydc, seeing a lot of test cases being updated :) , requesting one more which set the |
Signed-off-by: Guy Daich <guy.daich@sap.com>
Should be covered by |
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
|
looking good... thank you! |
arkodg
left a comment
There was a problem hiding this comment.
LGTM thanks !
there's one edge case that needs to be solved, can be a follow up.
For some cases, specifically when a Backend Filter exists, we create a
- Weighted xDS cluster for every route rule
- xDS cluster for every backendRef
lets track this with a GH issue
|
With this upstream change, this locality endpoints level metadata can be utilized as part of attribute, notably the extproc should be able to access that |
What type of PR is this?
What this PR does / why we need it:
Creates XDS filter metadata for cluster and endpoint resources, based on xRoute and Service/ServiceImport/Backend appropriately.
Which issue(s) this PR fixes:
Fixes #5523
Release Notes: Yes