Skip to content

feature(translator): cluster and endpoint xds metadata#5875

Merged
arkodg merged 11 commits intoenvoyproxy:mainfrom
guydc:feat-cluster-endpoint-metadata
May 21, 2025
Merged

feature(translator): cluster and endpoint xds metadata#5875
arkodg merged 11 commits intoenvoyproxy:mainfrom
guydc:feat-cluster-endpoint-metadata

Conversation

@guydc
Copy link
Contributor

@guydc guydc commented Apr 30, 2025

What type of PR is this?

What this PR does / why we need it:
Creates XDS filter metadata for cluster and endpoint resources, based on xRoute and Service/ServiceImport/Backend appropriately.

Which issue(s) this PR fixes:

Fixes #5523

Release Notes: Yes

@codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.52%. Comparing base (eb7266c) to head (915b4cb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/xds/translator/translator.go 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5875      +/-   ##
==========================================
+ Coverage   70.48%   70.52%   +0.04%     
==========================================
  Files         219      219              
  Lines       36318    36347      +29     
==========================================
+ Hits        25597    25634      +37     
+ Misses       9197     9192       -5     
+ Partials     1524     1521       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@guydc guydc force-pushed the feat-cluster-endpoint-metadata branch from e5aae01 to 19f47ee Compare May 15, 2025 00:01
@guydc guydc marked this pull request as ready for review May 15, 2025 00:02
@guydc guydc requested a review from a team as a code owner May 15, 2025 00:02
guydc added 6 commits May 16, 2025 08:59
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
@zirain zirain force-pushed the feat-cluster-endpoint-metadata branch from 768debb to ccde906 Compare May 16, 2025 00:59
@guydc guydc changed the title Feat cluster endpoint metadata feature(translator): cluster and endpoint xds metadata May 16, 2025
@guydc guydc added this to the v1.5.0 Release milestone May 16, 2025
@arkodg
Copy link
Contributor

arkodg commented May 16, 2025

thanks @guydc, seeing a lot of test cases being updated :) , requesting one more which set the name of a route rule, if this already exists, please ignore

Signed-off-by: Guy Daich <guy.daich@sap.com>
@guydc
Copy link
Contributor Author

guydc commented May 20, 2025

thanks @guydc, seeing a lot of test cases being updated :) , requesting one more which set the name of a route rule, if this already exists, please ignore

Should be covered by httproute-with-metadata.in.yaml, also added to egctl test default-resources.all.yaml demonstrating end-to-end of name from gw-api to xds.

guydc added 3 commits May 20, 2025 17:46
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
@mathetake
Copy link
Member

looking good... thank you!

@guydc guydc requested a review from arkodg May 21, 2025 17:46
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

there's one edge case that needs to be solved, can be a follow up.

For some cases, specifically when a Backend Filter exists, we create a

  • Weighted xDS cluster for every route rule
  • xDS cluster for every backendRef

lets track this with a GH issue

@arkodg arkodg requested review from a team May 21, 2025 18:03
@arkodg arkodg merged commit aa680b0 into envoyproxy:main May 21, 2025
44 of 45 checks passed
@mathetake
Copy link
Member

mathetake commented May 22, 2025

envoyproxy/envoy#39604

With this upstream change, this locality endpoints level metadata can be utilized as part of attribute, notably the extproc should be able to access that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Envoy xDS metadata for Cluster and LocalityLbEndpoints resources

4 participants