Skip to content

expr: add xds.upstream_host_locality_metadata#39604

Merged
agrawroh merged 2 commits intoenvoyproxy:mainfrom
mathetake:localityendpointmetadata
May 29, 2025
Merged

expr: add xds.upstream_host_locality_metadata#39604
agrawroh merged 2 commits intoenvoyproxy:mainfrom
mathetake:localityendpointmetadata

Conversation

@mathetake
Copy link
Member

@mathetake mathetake commented May 22, 2025

Commit Message:expr: add xds.upstream_host_locality_metadata
Additional Description:

Risk Level: low
Testing: done
Docs Changes: done
Release Notes: n/a
Platform Specific Features: n/a

@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #39604 was opened by mathetake.

see: more, trace.

@mathetake
Copy link
Member Author

Alternatively, we can add another attribute like xds.upstream_locality_metadata. i am open to suggestions...

@wbpcode could you take a look and let me know what you think is the best way forward?

mathetake added 2 commits May 27, 2025 15:57
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@mathetake mathetake force-pushed the localityendpointmetadata branch from 5ed7536 to 8bbb243 Compare May 27, 2025 16:54
@mathetake mathetake changed the title expr: fallback to locality metadata for upstream_host_metadata expr: add xds.upstream_host_locality_metadata May 27, 2025
@mathetake mathetake marked this pull request as ready for review May 27, 2025 18:11
@mathetake mathetake requested a review from wbpcode May 27, 2025 18:11
@mathetake
Copy link
Member Author

@wbpcode i made a change following your suggestion offline... PTAL when you get a chance!

Copy link
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@agrawroh agrawroh merged commit 41f5c45 into envoyproxy:main May 29, 2025
24 checks passed
@mathetake mathetake deleted the localityendpointmetadata branch May 29, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants