fix: set correct listenerContext order#535
Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom Oct 10, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #535 +/- ##
==========================================
+ Coverage 62.72% 62.81% +0.09%
==========================================
Files 42 42
Lines 4496 4497 +1
==========================================
+ Hits 2820 2825 +5
+ Misses 1532 1529 -3
+ Partials 144 143 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: bitliu <bitliu@tencent.com>
Xunzhuo
force-pushed
the
fix-listener-order
branch
from
e379463 to
11d6afa
Compare
Xunzhuo
changed the title
arkodg
reviewed
Oct 10, 2022
|
|
||
| if ctx := g.listeners[listenerName]; ctx != nil { | ||
| return ctx | ||
| for _, l := range g.listeners { |
Contributor
There was a problem hiding this comment.
if we take this approach of implicitly relying on input listener order, we'll no longer need to sort the listener Names in the o/p, can you also rm
gateway/internal/gatewayapi/sort.go
Line 48 in 34afca0
Merged
arkodg
approved these changes
Oct 10, 2022
Contributor
arkodg
left a comment
arkodg
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this issue ! this does make listener retrieval a little slower but it easier code to manage rather than add sort functions in the o/p
arkodg
pushed a commit
to arkodg/gateway
that referenced
this pull request
Oct 10, 2022
No longer needed now that order is maintained by using a list, thanks to envoyproxy#535 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg
added a commit
that referenced
this pull request
Oct 11, 2022
No longer needed now that order is maintained by using a list, thanks to #535 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #533
Signed-off-by: bitliu bitliu@tencent.com