Conversation
Codecov Report
@@ Coverage Diff @@
## main #402 +/- ##
==========================================
- Coverage 62.72% 62.49% -0.23%
==========================================
Files 42 45 +3
Lines 4496 5301 +805
==========================================
+ Hits 2820 3313 +493
- Misses 1532 1798 +266
- Partials 144 190 +46
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
4d2bca9 to
56f56db
Compare
internal/xds/translator/testdata/out/xds-ir/tls-route-passthrough.listeners.yaml
Outdated
Show resolved
Hide resolved
edc36cc to
2114d5a
Compare
|
This requires
Above tasks were added as part of this PR
|
danehans
left a comment
There was a problem hiding this comment.
@chauhanshubham the Kube provider RBAC needs to be updated for TLSRoutes.
9ad67d4 to
3f1b654
Compare
3f1b654 to
075b7db
Compare
11d0e32 to
4b4f062
Compare
4478f40 to
04ac43d
Compare
Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
Signed-off-by: Shubham Chauhan <shubham@tetrate.io> testfix Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
5c7b8fb to
c09d71c
Compare
| if !found { | ||
| r.resources.Namespaces.Delete(request.Namespace) | ||
| log.Info("deleted namespace from resource map") | ||
| r.resources.Services.Delete(request.NamespacedName) |
There was a problem hiding this comment.
This attempts to delete a possibly non-existent Service, and not the relevant ones. It is introducing an issue in the tlsroute controller, which was present for httproute controller too. I have filed an issue for this here #536
arkodg
left a comment
There was a problem hiding this comment.
LGTM, thanks for spending the extra cycles to get TLS Passthrough support in for 0.2.0 !
This commit adds a tlsroute controller which is further used to
configure tls passthrough in envoy.
Testing Done
Deployed the nginx application as mentioned here: https://istio.io/latest/docs/tasks/traffic-management/ingress/ingress-sni-passthrough/
Applied gateway configs as follows
Fixes #168
Signed-off-by: Shubham Chauhan shubham@tetrate.io