Skip to content

api: add full_duplex_streamed enum to ExtProcBodyProcessingMode#5349

Merged
arkodg merged 2 commits intoenvoyproxy:mainfrom
kfswain:main
Mar 6, 2025
Merged

api: add full_duplex_streamed enum to ExtProcBodyProcessingMode#5349
arkodg merged 2 commits intoenvoyproxy:mainfrom
kfswain:main

Conversation

@kfswain
Copy link
Copy Markdown
Contributor

@kfswain kfswain commented Feb 25, 2025

What type of PR is this?

What this PR does / why we need it:
FULL_DUPLEX_STREAMED is already a supported processing_mode, and was asked to be supported in our project (xref: kubernetes-sigs/gateway-api-inference-extension#388). I am currently using the patch policy to jsonPatch the field in, however it might be a simpler to expose the field via the more robust EnvoyExtensionPolicy
Which issue(s) this PR fixes:

Fixes #

Release Notes: Yes/No

@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Feb 25, 2025

hey @kfswain can you run make generate to generate the rest of the files
you can unblock yourself for now in v1.3.0 by using processingMode.allowModeOverride
https://gateway.envoyproxy.io/docs/api/extension_types/#extprocprocessingmode
cc @mathetake

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.16%. Comparing base (6afe0c9) to head (8aa3a37).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5349      +/-   ##
==========================================
- Coverage   65.20%   65.16%   -0.05%     
==========================================
  Files         212      212              
  Lines       33677    33678       +1     
==========================================
- Hits        21959    21946      -13     
- Misses      10396    10406      +10     
- Partials     1322     1326       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kfswain
Copy link
Copy Markdown
Contributor Author

kfswain commented Feb 25, 2025

can you run make generate to generate the rest of the files

Yes, apologies, I should have done that before cutting the PR. Done.

you can unblock yourself for now in v1.3.0 by using processingMode.allowModeOverride
https://gateway.envoyproxy.io/docs/api/extension_types/#extprocprocessingmode

Perfect, thank you!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we rm the proto file link, if an envoy proxy website link exists, lets add that

Copy link
Copy Markdown
Contributor Author

@kfswain kfswain Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG! I'll use: https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/http/ext_proc/v3/processing_mode.proto.html#enum-extensions-filters-http-ext-proc-v3-processingmode-bodysendmode

But it does seem to be missing a description for FULL_DUPLEX_STREAMED (I figure thats just a minor docs issue that doesnt need to block this PR)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah np at all, done: envoyproxy/envoy#38578

@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Mar 4, 2025

@kfswain can you run make generate again and commit those changes

kfswain added 2 commits March 6, 2025 16:01
Signed-off-by: Kellen Swain <kfswain@google.com>
Signed-off-by: Kellen Swain <kfswain@google.com>
@kfswain
Copy link
Copy Markdown
Contributor Author

kfswain commented Mar 6, 2025

@kfswain can you run make generate again and commit those changes

Done

@arkodg arkodg requested review from a team March 6, 2025 17:58
@arkodg arkodg merged commit 148bd62 into envoyproxy:main Mar 6, 2025
27 of 28 checks passed
@sanjaypujare
Copy link
Copy Markdown

@kfswain the docs still don't show this processing mode yet https://gateway.envoyproxy.io/docs/api/extension_types/#extprocbodyprocessingmode . Does it need to be done separately or is it just a matter of time (doc release process etc)?

@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Mar 27, 2025

@sanjaypujare its hasnt released yet, will be part of v1.4 / end April, its only part of the latest release https://gateway.envoyproxy.io/latest/api/extension_types/#extprocbodyprocessingmode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants