api: add full_duplex_streamed enum to ExtProcBodyProcessingMode#5349
api: add full_duplex_streamed enum to ExtProcBodyProcessingMode#5349arkodg merged 2 commits intoenvoyproxy:mainfrom
Conversation
|
hey @kfswain can you run |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5349 +/- ##
==========================================
- Coverage 65.20% 65.16% -0.05%
==========================================
Files 212 212
Lines 33677 33678 +1
==========================================
- Hits 21959 21946 -13
- Misses 10396 10406 +10
- Partials 1322 1326 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Yes, apologies, I should have done that before cutting the PR. Done.
Perfect, thank you! |
api/v1alpha1/ext_proc_types.go
Outdated
There was a problem hiding this comment.
can we rm the proto file link, if an envoy proxy website link exists, lets add that
There was a problem hiding this comment.
But it does seem to be missing a description for FULL_DUPLEX_STREAMED (I figure thats just a minor docs issue that doesnt need to block this PR)
There was a problem hiding this comment.
ah because there's an extra new line in https://github.com/envoyproxy/envoy/blob/cc9188ab83771aa23f54d4cf20e755a9169d9206/api/envoy/extensions/filters/http/ext_proc/v3/processing_mode.proto#L110, would be great if you could raise a PR to fix it
There was a problem hiding this comment.
Yeah np at all, done: envoyproxy/envoy#38578
|
@kfswain can you run |
Signed-off-by: Kellen Swain <kfswain@google.com>
Signed-off-by: Kellen Swain <kfswain@google.com>
Done |
|
@kfswain the docs still don't show this processing mode yet https://gateway.envoyproxy.io/docs/api/extension_types/#extprocbodyprocessingmode . Does it need to be done separately or is it just a matter of time (doc release process etc)? |
|
@sanjaypujare its hasnt released yet, will be part of v1.4 / end April, its only part of the latest release https://gateway.envoyproxy.io/latest/api/extension_types/#extprocbodyprocessingmode |
What type of PR is this?
What this PR does / why we need it:
FULL_DUPLEX_STREAMEDis already a supported processing_mode, and was asked to be supported in our project (xref: kubernetes-sigs/gateway-api-inference-extension#388). I am currently using the patch policy to jsonPatch the field in, however it might be a simpler to expose the field via the more robustEnvoyExtensionPolicyWhich issue(s) this PR fixes:
Fixes #
Release Notes: Yes/No