Skip to content

Typo fix for FULL_DUPLEX_STREAMED comments#38578

Closed
kfswain wants to merge 1 commit intoenvoyproxy:mainfrom
kfswain:typo-fix
Closed

Typo fix for FULL_DUPLEX_STREAMED comments#38578
kfswain wants to merge 1 commit intoenvoyproxy:mainfrom
kfswain:typo-fix

Conversation

@kfswain
Copy link
Copy Markdown

@kfswain kfswain commented Feb 26, 2025

Commit Message: Typo fix for FULL_DUPLEX_STREAMED comments
Additional Description: This is a small typo fix (just removes a newline) which will include the documentation for FULL_DUPLEX_STREAMED here

Risk Level: low
Testing: none

@repokitteh-read-only
Copy link
Copy Markdown

Hi @kfswain, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #38578 was opened by kfswain.

see: more, trace.

@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @abeyad
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #38578 was opened by kfswain.

see: more, trace.

@kfswain
Copy link
Copy Markdown
Author

kfswain commented Feb 26, 2025

This pr is related to: envoyproxy/gateway#5349

@abeyad
Copy link
Copy Markdown
Contributor

abeyad commented Feb 27, 2025

This just seems to add a bit extra whitespace at the bottom of the docs, is that correct?
Also, the DCO check failed - you need to sign your git commit (with git commit -s)

@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Mar 29, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 5, 2025

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api stale stalebot believes this issue/PR has not been touched recently waiting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants