Reset status conditions in GatewayAPI translator#516
Merged
danehans merged 4 commits intoenvoyproxy:mainfrom Oct 7, 2022
Merged
Reset status conditions in GatewayAPI translator#516danehans merged 4 commits intoenvoyproxy:mainfrom
danehans merged 4 commits intoenvoyproxy:mainfrom
Conversation
* reset the conditions field within the listeners field (Gateway status) and the the parents field (HTTPRoute Status) before further setting any newer conditions so older conditons that are no longer true can be reset. * Enhance the status updater to merge the listener and parents conditions so existing older conditions that are same as the newer ones (except the LastTransitionTime field) can be retained and writes to the API Server can be mitigated Fixes: envoyproxy#415 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Codecov Report
@@ Coverage Diff @@
## main #516 +/- ##
==========================================
+ Coverage 62.57% 62.82% +0.24%
==========================================
Files 41 41
Lines 4468 4479 +11
==========================================
+ Hits 2796 2814 +18
+ Misses 1528 1524 -4
+ Partials 144 141 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
This was referenced Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #415
Signed-off-by: Arko Dasgupta arko@tetrate.io