Updates ParentRef Status Conditions

[danehans]

Updates the Accepted condition type to use RouteReasonUnsupportedValue instead of the ResolvedRefs condition type.

Fixes #494

Signed-off-by: danehans daneyonhansen@gmail.com

[danehans]

@skriss with this PR an Accepted: False route is still considered an attached route from the parent Gateway. I would expect Accepted: False routes to not be attached. Is that correct?

[danehans]

@arkodg from my understanding of #516, this PR is still required.

[skriss]

@skriss with this PR an Accepted: False route is still considered an attached route from the parent Gateway. I would expect Accepted: False routes to not be attached. Is that correct?

Agree, I'd expect an Accepted: False route to not be attached to its parent(s).

[skriss]

From my read of the spec, we should either be ignoring the duplicate header, or appending its value:

• https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io/v1beta1.HTTPHeaderFilter
• https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io/v1beta1.HTTPHeader

But it doesn't seem like we need to be setting a condition here.

Regardless, the combo of Accepted: true with reason UnsupportedValue does not seem valid -- if we're using the UnsupportedValue reason, then the status should be False.

[LukeShu]

/cc @AliceProxy

[danehans]

From my read of the spec, we should either be ignoring the duplicate header, or appending its value:

The code currently ignores duplicate headers from the add/remove operations. Commit e3210aa no longer sets a status condition for these cases and therefore an Accepted=true condition is surfaced.

[codecov-commenter]

Codecov Report

Merging #495 (e3210aa) into main (5d5c28e) will increase coverage by 0.03%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #495      +/-   ##
==========================================
+ Coverage   60.21%   60.24%   +0.03%     
==========================================
  Files          45       45              
  Lines        5582     5564      -18     
==========================================
- Hits         3361     3352       -9     
+ Misses       2011     2003       -8     
+ Partials      210      209       -1     

Impacted Files	Coverage Δ
internal/gatewayapi/translator.go	85.52% <66.66%> (-0.23%)	⬇️
internal/provider/kubernetes/gatewayclass.go	68.84% <0.00%> (-1.45%)	⬇️
internal/provider/kubernetes/gateway.go	49.23% <0.00%> (-1.10%)	⬇️
internal/provider/kubernetes/tlsroute.go	59.72% <0.00%> (+6.01%)	⬆️
internal/provider/kubernetes/helpers.go	80.43% <0.00%> (+6.52%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[skriss]

Looks reasonable to me, and we'll likely revisit some of this with upcoming Gateway API spec changes around conditions.