Adds Gateway Watch to HTTPRoute Controller#403
Merged
danehans merged 1 commit intoenvoyproxy:mainfrom Sep 28, 2022
Merged
Conversation
danehans
force-pushed
the
issue_301_part2
branch
4 times, most recently
from
e1786d3 to
1de17fb
Compare
Merged
danehans
force-pushed
the
issue_301_part2
branch
from
1de17fb to
cd01a94
Compare
Contributor
Author
|
cd01a94 rebases to pull in CI conformance test coverage. |
arkodg
reviewed
Sep 27, 2022
Contributor
There was a problem hiding this comment.
curious how dequeue/deregister works
skriss
previously approved these changes
Sep 27, 2022
Contributor
skriss
left a comment
skriss
left a comment
There was a problem hiding this comment.
I'm OK with this in the interest of getting a demo release out, but I definitely think we need to look at #413 sooner than later. After merging this, if we have a Gateway with 10 HTTPRoutes attached, then any time the Gateway changes, we'll end up running at least 11 full translation loops, and likely more due to other inter-related watches. This is obviously not going to be scaleable.
danehans
force-pushed
the
issue_301_part2
branch
from
cd01a94 to
73d299f
Compare
Contributor
Author
|
Rebased to include #404. |
Contributor
Author
Signed-off-by: danehans <daneyonhansen@gmail.com>
skriss
previously approved these changes
Sep 28, 2022
danehans
force-pushed
the
issue_301_part2
branch
from
73d299f to
11e0f2e
Compare
skriss
approved these changes
Sep 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a watch for Gateway objects to the httproute controller. Valid HTTPRoutes that reference gateways managed by EG will be enqueued for reconciliation.
Partially Fixes: #301