Skip to content

feat: Set --cpuset-threads in EnvoyProxy cmdline arg #1727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zirain merged 2 commits into from
Jul 31, 2023
Merged

feat: Set --cpuset-threads in EnvoyProxy cmdline arg #1727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
231a29b
Set `--cpuset-threads` in EnvoyProxy cmdline arg
Jul 28, 2023
15e4b7c
lint
Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ func expectedProxyContainers(infra *ir.ProxyInfra, deploymentConfig *egcfgv1a1.K
fmt.Sprintf("--service-node $(%s)", envoyPodEnvVar),
fmt.Sprintf("--config-yaml %s", bootstrapConfigurations),
fmt.Sprintf("--log-level %s", logLevel),
"--cpuset-threads",
}
if componentLogLevel := componentLogLevelArgs(proxyLogging.Level); componentLogLevel != "" {
args = append(args, fmt.Sprintf("--component-log-level %s", componentLogLevel))
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/bootstrap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ spec:
- --service-node $(ENVOY_POD_NAME)
- --config-yaml test bootstrap config
- --log-level warn
- --cpuset-threads
command:
- envoy
env:
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/component-level.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ spec:
- --service-node $(ENVOY_POD_NAME)
- --config-yaml test bootstrap config
- --log-level error
- --cpuset-threads
- --component-log-level filter:info
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/custom.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ spec:
resource_api_version: V3
name: runtime-0
- --log-level warn
- --cpuset-threads
command:
- envoy
env:
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/default-env.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ spec:
resource_api_version: V3
name: runtime-0
- --log-level warn
- --cpuset-threads
command:
- envoy
env:
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ spec:
resource_api_version: V3
name: runtime-0
- --log-level warn
- --cpuset-threads
command:
- envoy
env:
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/enable-prometheus.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ spec:
resource_api_version: V3
name: runtime-0
- --log-level warn
- --cpuset-threads
command:
- envoy
env:
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/extension-env.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ spec:
resource_api_version: V3
name: runtime-0
- --log-level warn
- --cpuset-threads
command:
- envoy
env:
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/volumes.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ spec:
resource_api_version: V3
name: runtime-0
- --log-level warn
- --cpuset-threads
command:
- envoy
env:
Expand Down