feat: Set --cpuset-threads in EnvoyProxy cmdline arg#1727
Merged
zirain merged 2 commits intoenvoyproxy:mainfrom Jul 31, 2023
Merged
feat: Set --cpuset-threads in EnvoyProxy cmdline arg#1727zirain merged 2 commits intoenvoyproxy:mainfrom
--cpuset-threads in EnvoyProxy cmdline arg#1727zirain merged 2 commits intoenvoyproxy:mainfrom
Conversation
* Use cpuset size instead of total hardware threads to determine total worker threads. * Can be overridden by explicitly setting `--concurrency` arg More in https://www.envoyproxy.io/docs/envoy/latest/operations/cli#cmdoption-cpuset-threads Discussion in envoyproxy/envoy#5975 Relates to envoyproxy#1718 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Codecov Report
@@ Coverage Diff @@
## main #1727 +/- ##
==========================================
- Coverage 64.86% 64.83% -0.04%
==========================================
Files 83 83
Lines 11924 11925 +1
==========================================
- Hits 7735 7731 -4
- Misses 3707 3711 +4
- Partials 482 483 +1
|
zirain
approved these changes
Jul 31, 2023
Xunzhuo
approved these changes
Jul 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use cpuset size instead of total hardware threads to determine total worker threads.
Can be overridden by explicitly setting
--concurrencyargMore in https://www.envoyproxy.io/docs/envoy/latest/operations/cli#cmdoption-cpuset-threads
Discussion in envoyproxy/envoy#5975
Relates to #1718