util: Add test for MemBlockBuilder::release(), which was not working (discovered in #8779).#9360
Merged
jmarantz merged 3 commits intoenvoyproxy:masterfrom Dec 16, 2019
Merged
Conversation
…xy#8779). Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
previously approved these changes
Dec 16, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM w/ one optional comment.
Signed-off-by: Joshua Marantz <jmarantz@google.com>
jmarantz
added a commit
to jmarantz/envoy
that referenced
this pull request
Dec 16, 2019
Signed-off-by: Joshua Marantz <jmarantz@google.com>
jmarantz
added a commit
to jmarantz/envoy
that referenced
this pull request
Dec 16, 2019
Signed-off-by: Joshua Marantz <jmarantz@google.com>
prakhag1
pushed a commit
to prakhag1/envoy
that referenced
this pull request
Jan 3, 2020
…(discovered in envoyproxy#8779). (envoyproxy#9360) * Add test for release(), which was not working (discovered in envoyproxy#8779). Signed-off-by: Joshua Marantz <jmarantz@google.com> Signed-off-by: Prakhar <prakhar_au@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Follow-up to #9306 which added a release() method, but after moving to an internal span representation it stopped working, and there was not a unit test for it. This adds the unit test and fixes the impl. I had promised follow-ups on 2 other issues raised by @mattklein123 in #9306 , but I'm leaning against one of them, and modified the other.
Risk Level: low
Testing: just the MemBlockBuilder test.
Docs Changes: n/a
Release Notes: n/a