ext_authz: Make sure injectContext is called#8961
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Nov 9, 2019
dio:inject-context-6520
Merged
ext_authz: Make sure injectContext is called#8961mattklein123 merged 1 commit intoenvoyproxy:masterfrom dio:inject-context-6520
injectContext is called#8961mattklein123 merged 1 commit intoenvoyproxy:masterfrom
dio:inject-context-6520
Conversation
This patch makes sure active span `injectContext` is called before making the check request for the HTTP implementation of `ext_authz`. Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
mattklein123
approved these changes
Nov 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This patch makes sure active span
injectContextis called before making the check request for the HTTP implementation ofext_authz.Risk Level: Low
Testing: unit tests, manual validation against the repo by @enbohm (enbohm/envoy-tracing#1).
Docs Changes: N/A
Release Notes: N/A
Fixes #6520
Signed-off-by: Dhi Aurrahman dio@tetrate.io