http1 encode trailers in chunk encoding#8667
Merged
mattklein123 merged 69 commits intoenvoyproxy:masterfrom Dec 17, 2019
Merged
http1 encode trailers in chunk encoding#8667mattklein123 merged 69 commits intoenvoyproxy:masterfrom
mattklein123 merged 69 commits intoenvoyproxy:masterfrom
Conversation
Member
|
Thanks for adding this. This will need both unit tests for the codec as well as integration tests. Thank you! /wait |
Allows encoding the trailers in chunk encoding Signed-off-by: Chuong Vu <chuongv@google.com>
Chuongv
force-pushed
the
http1-trailers-chunk-encoding
branch
from
20e428a to
08ae97c
Compare
Contributor
Author
|
@htuch your thoughts on this would be great! Also I tested this locally and was able to get the trailers back. However I'm having a hard time simulating what I did in an integration test. So I would love some feedback on how I can properly incorporate the proper test. |
Member
|
@Chuongv looks like you are on the right track.. |
Signed-off-by: Chuong Vu <chuongv@google.com>
Chuongv
commented
Oct 24, 2019
Chuongv
commented
Oct 24, 2019
Signed-off-by: Chuong Vu <chuongv@google.com>
Chuongv
changed the title
Chuongv
changed the title
Signed-off-by: Chuong Vu <chuongv@google.com>
Signed-off-by: Chuong Vu <chuongv@google.com>
Signed-off-by: Chuong Vu <chuongv@google.com>
Cleaning up some of the code that was unnecessary Signed-off-by: Chuong Vu <chuongv@google.com>
onHeadersComplete is never called after trailers are done Signed-off-by: Chuong Vu <chuongv@google.com>
Signed-off-by: Chuong Vu <chuongv@google.com>
Signed-off-by: Chuong Vu <chuongv@google.com>
alyssawilk
reviewed
Dec 11, 2019
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
Looking good. Two last nits from me and I've pinged Lizan to take a look at the bridge filter.
snowp
previously requested changes
Dec 11, 2019
Contributor
snowp
left a comment
snowp
left a comment
There was a problem hiding this comment.
Looks pretty good! Left a few comments
Signed-off-by: Chuong Vu <chuongv@google.com>
Member
|
Needs a master merge. Thank you! /wait |
Signed-off-by: Chuong Vu <chuongv@google.com>
mattklein123
requested changes
Dec 13, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM w/ a few small nits. Thanks for powering through this. @alyssawilk @snowp any further comments?
/wait
alyssawilk
previously approved these changes
Dec 16, 2019
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
LGTM modulo Matt's latest round of comments.
I was good other than wanting a second pair of eyes on the reverse bridge filter, and Snow did a pass on that.
Signed-off-by: Chuong Vu <chuongv@google.com>
spenceral
added a commit
to spenceral/envoy
that referenced
this pull request
Dec 20, 2019
* master: (167 commits) stats: Avoid asserts in fuzz-tests by eliminating arbitrary length limits, using the new MemBlock wrapper for memcpy (envoyproxy#8779) Make %UPSTREAM_LOCAL_ADDRESS% access-log format work for HTTP requests. (envoyproxy#9362) tools: API boosting support for using decls and enum constants. (envoyproxy#9418) Fix incorrect cluster InitializePhase type (envoyproxy#9379) build: fix merge race between envoyproxy#9241 and envoyproxy#9413. (envoyproxy#9427) fuzz: fix incorrect evaluator test (envoyproxy#9402) server: fix bogus startup log message (envoyproxy#9404) tools: Add protoxform tests (envoyproxy#9241) api: options after import (envoyproxy#9413) misc: use std::move instead of constructing a copy (envoyproxy#9415) tools: API boosting support for rewriting elaborated types. (envoyproxy#9375) docs: fix invalid transport_socket value (envoyproxy#9403) fix typo in docs (envoyproxy#9394) srds: remove to-de-removed scopes first and then apply additions to avoid scope key conflict. (envoyproxy#9366) api: generate whole directory and sync (envoyproxy#9382) bazel: Add load statements for proto_library (envoyproxy#9367) Fix typo (envoyproxy#9388) Correct test of OptionsImpl argc type (Was: Correct type for std::array size() result) (envoyproxy#9290) http1 encode trailers in chunk encoding (envoyproxy#8667) Add mode to PipeInstance (envoyproxy#8423) ...
prakhag1
pushed a commit
to prakhag1/envoy
that referenced
this pull request
Jan 3, 2020
Signed-off-by: Chuong Vu <chuongv@google.com> Signed-off-by: Prakhar <prakhar_au@yahoo.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add HTTP1 encoding and decoding of trailers
Encoding/Decoding of HTTP1 trailers is set behind the flag
enable_trailersChanges made:
Signed-off-by: Chuong Vu chuongv@google.com
Description: Pass trailers through from http2 upstream to http1 downstream
Risk Level: Med
Testing: Unit test and integration test with every combination of H1 and H2
Docs Changes: N/A
Release Notes:
Fixes #7149