Enable configuration of "enable_trailers" protocol setting#78
Closed
yabberyabber wants to merge 1 commit intoaristanetworks:masterfrom
Closed
Enable configuration of "enable_trailers" protocol setting#78yabberyabber wants to merge 1 commit intoaristanetworks:masterfrom
yabberyabber wants to merge 1 commit intoaristanetworks:masterfrom
Conversation
af1465f to
ae60c04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
envoyproxy/envoy#8667 This change in envoy creates the new http_protocol_options.enable_trailers flag which preserves HTTP trailers when bridging between http{1,2}.
This PR adds a way to set this flag via ambassador config.
Just set the enable_trailers flag in the ambassador annotation and it should be propagated to the underlying envoy config.
This implementation is heavily inspired by this PR https://github.com/emissary-ingress/emissary/pull/1484/files which implements a similar change for the enable_http10 flag which also goes under http_protocol_options.
Related Issues
List related issues.
Testing
I've added a unit test for this and will be testing in arista's infra cluster.
Checklist
Does my change need to be backported to a previous release?
I made sure to update
CHANGELOG.md.Remember, the CHANGELOG needs to mention:
This is unlikely to impact how Ambassador performs at scale.
Remember, things that might have an impact at scale include:
My change is adequately tested.
Remember when considering testing:
I updated
DEVELOPING.mdwith any any special dev tricks I had to use to work on this code efficiently.The changes in this PR have been reviewed for security concerns and adherence to security best practices.