Skip to content

zk: remove explicit specifier from multi-parameter constructor#7828

Closed
derekargueta wants to merge 1 commit intoenvoyproxy:masterfrom
derekargueta:dereka/unnecessary-explicit
Closed

zk: remove explicit specifier from multi-parameter constructor#7828
derekargueta wants to merge 1 commit intoenvoyproxy:masterfrom
derekargueta:dereka/unnecessary-explicit

Conversation

@derekargueta
Copy link
Member

@derekargueta derekargueta commented Aug 5, 2019

Description: explicit is only needed for single-parameter constructors to avoid using it for implicit conversions. cc @rgs1
Risk Level: low
Testing: included
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Derek Argueta darguetap@gmail.com

Signed-off-by: Derek Argueta <darguetap@gmail.com>
@derekargueta derekargueta requested a review from snowp as a code owner August 5, 2019 05:46
@jmarantz jmarantz self-assigned this Aug 6, 2019
@jmarantz
Copy link
Contributor

jmarantz commented Aug 6, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@derekargueta
Copy link
Member Author

I'd prefer to close this and have this fixed in #7825 so let's not merge yet cc @rgs1

@stale
Copy link

stale bot commented Aug 13, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Aug 13, 2019
@jmarantz jmarantz closed this Aug 18, 2019
@jmarantz
Copy link
Contributor

closed per @derekargueta 's request

@derekargueta derekargueta deleted the dereka/unnecessary-explicit branch October 8, 2019 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale stalebot believes this issue/PR has not been touched recently

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants