Register per opcode latencies#7825
Merged
snowp merged 9 commits intoenvoyproxy:masterfrom Aug 13, 2019
Merged
Conversation
This change adds histograms for each opcode, e.g.: * getdata * setdata * ... Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Member
Author
|
Note: tests are still missing, will add them later today/tomorrow. |
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Contributor
|
sorry, just checking something. /checkowners! |
|
🙀 Error while processing event: |
This comment has been minimized.
This comment has been minimized.
derekargueta
reviewed
Aug 5, 2019
snowp
suggested changes
Aug 6, 2019
Contributor
snowp
left a comment
snowp
left a comment
There was a problem hiding this comment.
looks good to me, just need some test coverage
added 5 commits
August 7, 2019 11:40
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Contributor
|
looks like CI is failing |
Member
Author
|
yeah i need to update the stat name lookups to conform with #7810, will follow-up in a bit. |
added 2 commits
August 10, 2019 09:19
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Member
Author
|
per offline conversation with @snowp, testing the existence of the histograms should be enough. |
rgs1
pushed a commit
to rgs1/envoy
that referenced
this pull request
Jul 23, 2020
This was missed in envoyproxy#7825. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
zuercher
pushed a commit
that referenced
this pull request
Jul 27, 2020
This was missed in #7825. Risk Level: low Docs Change: docs only Release Notes: n/a Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
KBaichoo
pushed a commit
to KBaichoo/envoy
that referenced
this pull request
Jul 30, 2020
This was missed in envoyproxy#7825. Risk Level: low Docs Change: docs only Release Notes: n/a Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com> Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
This was missed in envoyproxy#7825. Risk Level: low Docs Change: docs only Release Notes: n/a Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
This was missed in envoyproxy#7825. Risk Level: low Docs Change: docs only Release Notes: n/a Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com> Signed-off-by: chaoqinli <chaoqinli@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds histograms for each opcode, e.g.:
Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com