stats: convert Dynamo stats to use StatName interface#7634
Merged
jmarantz merged 12 commits intoenvoyproxy:masterfrom Jul 24, 2019
Merged
stats: convert Dynamo stats to use StatName interface#7634jmarantz merged 12 commits intoenvoyproxy:masterfrom
jmarantz merged 12 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
jmarantz
changed the title
Member
|
/assign @mattklein123 Feel free to reassign -- just looks like you're the one of the few people who's touched the logic in here. |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
…rs by string. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
OK this is ready for a look -- I removed dynamo_stats_filter from the whitelist established in #7573 . Feel free to push back on the potential lookup-by-name in the request-path if you think it's an issue, and we can discuss how to resolve. |
…he format message. Signed-off-by: Joshua Marantz <jmarantz@google.com>
jmarantz
commented
Jul 23, 2019
mattklein123
requested changes
Jul 23, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, cool stuff. Flushing out some comments from a first pass and then will take another look. Thank you!
/wait
| } | ||
|
|
||
| Stats::StatName DynamoStats::getStatName(const std::string& str) { | ||
| // We have been presented with a string to when composing a stat. The Dynamo |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
requested changes
Jul 24, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, LGTM with 2 small comments.
/wait
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
Thanks for the review & catching some unneeded stuff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: I started off thinking I would try to knock off a bunch of the places where we compute stats by name in one go, but Dynamo deserves its own PR mostly; there's one unrelated file in it. If this goes in first we should remove the whitelist entry in #7573 and if that goes in first then we should merge that in and remove the entry before checking this one in.
This is another step toward resolving #4196 and enabling submission of #4980.
Risk Level: medium -- could introduce lock contention for stats associated with status-codes and table-names. This PR may need more work because of that. Note that #7008 offers a solution to this problem; it's just not clear yet whether it's worth the cost until we see perf traces.
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a