stats: use counterFromStatName for ratelimit filters#7573
Merged
jmarantz merged 12 commits intoenvoyproxy:masterfrom Jul 23, 2019
Merged
stats: use counterFromStatName for ratelimit filters#7573jmarantz merged 12 commits intoenvoyproxy:masterfrom
jmarantz merged 12 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
… in the codebase. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
jmarantz
changed the title
Contributor
Author
|
/retest |
|
🔨 rebuilding |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM with 2 questions.
/wait-any
| const bool failure_mode_deny_; | ||
| const absl::optional<Grpc::Status::GrpcStatus> rate_limited_grpc_status_; | ||
| Http::Context& http_context_; | ||
| Stats::StatNamePool stat_name_pool_; |
Member
There was a problem hiding this comment.
Any reason to not just embed this inside the StatNames structure on the next line? It seems like that would be less magical?
| echo "Installing requirements..." | ||
| pip3 install --upgrade pip | ||
| pip3 install -r requirements.txt | ||
| pip3 -q install --upgrade pip |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Another in a series of PRs to save StatNames at construction time, for lock-free-in-hot-path creation of scoped stats at request-time. This one captures the rate-limiting related stats, which occur in two different filters.
This PR also adds a formatting check to avoid direct calls to create counters, gauges, and histograms by name. Because there are still some remaining offenders, a whitelist is added with comments/TODOs to remove from this list until they are gone.
This is another step toward resolving #4196 and enabling submission of #4980.
Risk Level: low
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a