Skip to content

api filter http: add build rules for go protobufs #7526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
htuch merged 2 commits into from
Jul 12, 2019
Merged

api filter http: add build rules for go protobufs #7526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b27f88a
api filter http: add build rules for go protobufs
nareddyt Jul 10, 2019
e71f365
Fix invalid dependency target
nareddyt Jul 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion api/envoy/config/filter/http/jwt_authn/v2alpha/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
licenses(["notice"]) # Apache 2

load("@envoy_api//bazel:api_build_system.bzl", "api_proto_library_internal")
load("@envoy_api//bazel:api_build_system.bzl", "api_go_proto_library", "api_proto_library_internal")

api_proto_library_internal(
name = "jwt_authn",
Expand All @@ -11,3 +11,13 @@ api_proto_library_internal(
"//envoy/api/v2/route",
],
)

api_go_proto_library(
Copy link
Copy Markdown
Member

@htuch htuch Jul 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyessenov how come we don't just have this embedded in api_proto_library_internal? This seems like a bunch of boilerplate that we could potentially eliminate.

name = "jwt_authn",
proto = ":jwt_authn",
deps = [
"//envoy/api/v2/core:base_go_proto",
"//envoy/api/v2/core:http_uri_go_proto",
"//envoy/api/v2/route:route_go_proto",
],
)
8 changes: 7 additions & 1 deletion api/envoy/config/filter/http/router/v2/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("@envoy_api//bazel:api_build_system.bzl", "api_proto_library_internal")
load("@envoy_api//bazel:api_build_system.bzl", "api_go_proto_library", "api_proto_library_internal")

licenses(["notice"]) # Apache 2

Expand All @@ -7,3 +7,9 @@ api_proto_library_internal(
srcs = ["router.proto"],
deps = ["//envoy/config/filter/accesslog/v2:accesslog"],
)

api_go_proto_library(
name = "router",
proto = ":router",
deps = ["//envoy/config/filter/accesslog/v2:accesslog_go_proto"],
)
7 changes: 6 additions & 1 deletion api/envoy/config/filter/http/transcoder/v2/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
load("@envoy_api//bazel:api_build_system.bzl", "api_proto_library_internal")
load("@envoy_api//bazel:api_build_system.bzl", "api_go_proto_library", "api_proto_library_internal")

licenses(["notice"]) # Apache 2

api_proto_library_internal(
name = "transcoder",
srcs = ["transcoder.proto"],
)

api_go_proto_library(
name = "transcoder",
proto = ":transcoder",
)