api filter http: add build rules for go protobufs#7526
Merged
htuch merged 2 commits intoenvoyproxy:masterfrom Jul 12, 2019
Merged
api filter http: add build rules for go protobufs#7526htuch merged 2 commits intoenvoyproxy:masterfrom
htuch merged 2 commits intoenvoyproxy:masterfrom
Conversation
All http filters have build rules to generate cc protobufs, but not go protobufs. Added build rules to generate go protobuf files. Emulates the rules in the `health_check` http filter. Signed-off-by: Teju Nareddy <nareddyt@google.com>
htuch
suggested changes
Jul 11, 2019
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Thanks, needs to pass CI though.
/wait
Signed-off-by: Teju Nareddy <nareddyt@google.com>
htuch
approved these changes
Jul 12, 2019
| ], | ||
| ) | ||
|
|
||
| api_go_proto_library( |
Member
There was a problem hiding this comment.
@kyessenov how come we don't just have this embedded in api_proto_library_internal? This seems like a bunch of boilerplate that we could potentially eliminate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: All http filters have build rules to generate cc protobufs, but not go protobufs. Added build rules (to a few filters) to generate go protobuf files. Emulates the rules in the
health_checkhttp filter.Risk Level: Low
Testing: These rules were copied to google3 and tested internally. Unfortunately, I am having a bit of trouble with
bazel builddirectly on these targets ("Package is considered deleted due to --deleted_packages"). Please let me know if there is a better way to test this change.Docs Changes: N/A
Release Notes: N/A