doc: update obsolete ref to api/XDS_PROTOCOL.md#7002
Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom May 22, 2019
Merged
doc: update obsolete ref to api/XDS_PROTOCOL.md#7002mattklein123 merged 4 commits intoenvoyproxy:masterfrom
mattklein123 merged 4 commits intoenvoyproxy:masterfrom
Conversation
mattklein123
requested changes
May 19, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks for doing this. Please switch these all to proper :ref: links. The primary reason we moved this file was to get better linking.
/wait
fixed by ``` grep XDS_PROTOCOL.md -rnl api include docs source | \ xargs sed -i 's/XDS_PROTOCOL.md/xds_protocol.rst/g' ``` Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Contributor
Author
|
Will update. |
Member
|
|
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
mattklein123
requested changes
May 21, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Awesome, thank you! One missing switch.
/wait
api/envoy/api/v2/rds.proto
Outdated
| // <envoy_api_msg_route.VirtualHost.domains>` field. The *resource_names_unsubscribe* field contains | ||
| // a list of virtual host names that have been `unsubscribed | ||
| // <https://github.com/envoyproxy/envoy/blob/master/api/XDS_PROTOCOL.md#unsubscribing-from-resources>`_ | ||
| // <https://github.com/envoyproxy/envoy/blob/master/api/xds_protocol.rst#unsubscribing-from-resources>`_ |
Contributor
Author
There was a problem hiding this comment.
Too excited about the 0 warning and didn't realize this one does't give warning. Fixed now
mattklein123
previously approved these changes
May 21, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thank you this is awesome.
Member
|
Oops sorry looks like this needs a format fix. /wait |
Contributor
Author
|
This is not good. |
Contributor
Author
|
I realize that this piece of comment is associated with
|
Contributor
Author
|
created #7030 |
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
May 22, 2019
* master: (65 commits) proto: Add PATCH method to RequestMethod enum (envoyproxy#6737) exe: drop unused deps on zlib compressor code (envoyproxy#7022) coverage: fix some misc coverage (envoyproxy#7033) Enable proto schema for router_check_tool (envoyproxy#6992) stats: rework stat sink flushing to centralize counter latching (envoyproxy#6996) [test] convert lds api test config stubs to v2 (envoyproxy#7021) router: scoped rds (2c): implement scoped rds API (envoyproxy#6932) build: Add option for size-optimized binary (envoyproxy#6960) test: adding an integration test framework for file-based LDS (envoyproxy#6933) doc: update obsolete ref to api/XDS_PROTOCOL.md (envoyproxy#7002) dispatcher: faster runOnAllThreads (envoyproxy#7011) example: add csrf sandbox (envoyproxy#6805) fix syntax of gcov exclusion zone. (envoyproxy#7023) /runtime_modify: add support for query params in body (envoyproxy#6977) stats: Create stats for http codes with the symbol table. (envoyproxy#6733) health check: fix more fallout from inline deletion change (envoyproxy#6988) Max heap fix (envoyproxy#7016) Add support to unregister from lifecycle notifications (envoyproxy#6984) build spdy_core_alt_svc_wire_format (envoyproxy#7010) ext_authz: Make sure initiateCall only called once (envoyproxy#6949) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
replace
XDS_PROTOCOL.mdby:ref: xds_protocol seriesSigned-off-by: Yuchen Dai silentdai@gmail.com
Risk Level: None
Testing: None
Docs Changes: fix only
Release Notes: None