Kafka codec: refactor (nullable)string/bytes deserializers so they ut…#6851
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom May 8, 2019
Merged
Conversation
…ilize the same feed code Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Contributor
Author
|
/retest |
|
🔨 rebuilding |
mattklein123
requested changes
May 7, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Awesome, thanks for the cleanup. Tiny nit.
/wait
| * @return number of bytes consumed. | ||
| */ | ||
| template <typename DeserializerType, typename LengthType, typename ByteType> | ||
| size_t feed_bytes_into_buffers(absl::string_view& data, DeserializerType& length_deserializer, |
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Contributor
Author
|
/retest |
|
🔨 rebuilding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ilize the same feed code
There were 4 deserializers that were basically doing the same thing:
lengthand handle null valueThis commit refactors all of that so the code stays in one place.
Discussed before in:
#6831 (review)
and
#4950 (comment)
Description:
Risk Level: Low (new Kafka codec that's not active anyways)
Testing: automated tests
Docs Changes: n/a
Release Notes: n/a