Kafka codec: avoid memcpy-ing data in serializers when the bytes to c…#6831
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom May 6, 2019
Merged
Conversation
…opy are 0 Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Member
|
/retest |
|
🔨 rebuilding |
mattklein123
approved these changes
May 6, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, this looks good to me. My preference would be to collapse all of this common logic into a helper function which isn't duplicated, but maybe do that in a follow up so we can unbreak this build with this PR? Thanks for the quick turnaround.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…opy are 0
Description:
As in title, avoids a situation when we invoke
what causes asan to complain.
Testing on CI, because my mac build complains.
Risk Level: low (minor change to new code)
Testing: Will merge if ASAN CI is happy
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]