Rollforward of api: Add total_issued_requests to Upstream Locality and Endpoint Stats. (#6692)#6784
Conversation
|
Waiting to see if coverage passes. |
|
Coverage still hangs at IpVersions/LoadStatsIntegrationTest.LocalityWeighted/IPv4 even after increasing coverage timeout to 8000secs. This looks like a real issue. Not sure why this manifests only during coverage run. Any pointers to debug this further @lizan ? The following PASS locally: ./ci/run_envoy_docker.sh './ci/do_ci.sh bazel.coverage' locally fails with some other error: |
|
@karthikbox please merge master and try again, there has been a lot of churn recently in CI. |
karthikbox
force-pushed
the
rollforward_lrs
branch
from
6839862 to
4501d84
Compare
|
It is a real issue because coverage run link all tests into a single binary and run all tests in one process, it may keep stats from other tests in that case. |
karthikbox
force-pushed
the
rollforward_lrs
branch
from
4501d84 to
0c0ef2a
Compare
karthikbox
force-pushed
the
rollforward_lrs
branch
9 times, most recently
from
1c05216 to
3e0a634
Compare
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Can you do a --runs_per_test=500 on the load_stats_integration_test to provide some confidence that flakes are gone? Thanks. LGTM and ready to ship modulo the comment followup and this.
/wait
karthikbox
force-pushed
the
rollforward_lrs
branch
from
3e0a634 to
a683269
Compare
|
Ran test //test/integration:load_stats_integration_test 1000 times locally. No failures. |
…d Endpoint Stats. (envoyproxy#6692) Changes: Fixes coverage test hang. No change to core logic from envoyproxy#6692. Signed-off-by: Karthik Reddy <rekarthik@google.com>
karthikbox
force-pushed
the
rollforward_lrs
branch
from
a683269 to
d86a5c0
Compare
* master: (88 commits) upstream: Null-deref on TCP health checker if setsockopt fails (envoyproxy#6793) ci: switch macOS CI to azure pipelines (envoyproxy#6889) os syscalls lib: break apart syscalls used for hot restart (envoyproxy#6880) Kafka codec: precompute request size before serialization, so we do n… (envoyproxy#6862) upstream: move static and strict_dns clusters to dedicated files (envoyproxy#6886) Rollforward of api: Add total_issued_requests to Upstream Locality and Endpoint Stats. (envoyproxy#6692) (envoyproxy#6784) fix explicit constructor in copy-initialization (envoyproxy#6884) stats: use tag iterator rather than constructing the tag-array and searching that. (envoyproxy#6853) common: use unscoped build target in generate_version_linkstamp (envoyproxy#6877) Addendum to envoyproxy#6778 (envoyproxy#6882) ci: add minimum Linux build for Azure Pipelines (envoyproxy#6881) grpc: utilities for inter-converting grpc::ByteBuffer and Buffer::Instance. (envoyproxy#6732) upstream: allow excluding hosts from lb calculations until initial health check (envoyproxy#6794) stats: prevent unused counters from leaking across hot restart (envoyproxy#6850) network filters: add `injectDataToFilterChain(data, end_stream)` method to network filter callbacks (envoyproxy#6750) delete things that snuck back in (envoyproxy#6873) config: scoped rds (2b): support delta APIs in ConfigProvider framework (envoyproxy#6781) string == string! (envoyproxy#6868) config: add mssing imports to delta_subscription_state (envoyproxy#6869) protobuf: add missing default case to enum (envoyproxy#6870) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
3 participants
No new changes.
Signed-off-by: Karthik Reddy rekarthik@google.com