api: Add total_issued_requests to Upstream Locality and Endpoint Stats.#6692
Merged
htuch merged 2 commits intoenvoyproxy:masterfrom Apr 29, 2019
Merged
api: Add total_issued_requests to Upstream Locality and Endpoint Stats.#6692htuch merged 2 commits intoenvoyproxy:masterfrom
htuch merged 2 commits intoenvoyproxy:masterfrom
Conversation
Contributor
|
/assign htuch |
htuch
suggested changes
Apr 24, 2019
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Looks good; needs format fix as well as a few comments to follow up on.
/wait
added 2 commits
April 26, 2019 21:54
Description: This field tracks the count of requests issued since the last report. This field will be used for global load balancing decisions. Risk Level: Low Testing: Compiles successfully. Signed-off-by: Karthik Reddy <rekarthik@google.com>
Description: Envoy maintains a stats counter rq_total to track total requests made. By latching this counter when load reporting period begins, we are able to count the total requests issued in a load reporting interval. This information is then reported to management server via the field total_issued_requests. Risk Level: Low Testing: //test/integration:load_stats_reporter passes. Docs: Updated inline. Release notes: api: track and report requests issued since last load report. Signed-off-by: Karthik Reddy <rekarthik@google.com>
Author
|
Please take a look again. |
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
May 1, 2019
* master: (35 commits) Revert "api: Add total_issued_requests to Upstream Locality and Endpoint Stats. (envoyproxy#6692)" (envoyproxy#6761) Add test for the SocketOptionFactory::buildLiteralOptions() method. (envoyproxy#6724) Add test of parsing weighted_cluster route configuration to improve test coverage. (envoyproxy#6711) test: reducing H2 test permutations, increasing coverage time (envoyproxy#6753) Support gRPC-JSON translate without the google.api.http option. (envoyproxy#6731) quiche: implement QuicEpollClock (envoyproxy#6745) http: rc details for main Envoy workflow (envoyproxy#6560) quiche: implement QuicSystemEventLoopImpl (envoyproxy#6723) http: tracking 100s from upstream in stats (envoyproxy#6746) coverage: run without deprecated option (envoyproxy#6752) quiche: Implement spdy_test_helpers_impl. (envoyproxy#6741) [test] convert listener test stubs to v2 API (envoyproxy#6735) api: Add total_issued_requests to Upstream Locality and Endpoint Stats. (envoyproxy#6692) quiche: Implement http2_reconstruct_object_impl.h. (envoyproxy#6717) build: patch protobuf for UBSAN issue. (envoyproxy#6721) router: scoped rds (2a): scoped routing configuration protos (envoyproxy#6675) tap: use move semantics for submitTrace (envoyproxy#6709) quiche: add epoll_server for testing (envoyproxy#6650) Increase timeout of the coverage test run to 3000 seconds as it is now bumping in the current 2000s limit causing coverage run to abort sometimes. (envoyproxy#6722) quiche: Update tarball to commit 43a1c0f10f2855c3cd142f500e8d19ac6d6f5a8c (envoyproxy#6718) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
jeffpiazza-google
pushed a commit
to jeffpiazza-google/envoy
that referenced
this pull request
May 3, 2019
…s. (envoyproxy#6692) total_issued_requests field tracks the count of requests issued since the last report. This field will be used for global load balancing decisions. Envoy maintains a stats counter rq_total to track total requests made. By latching this counter when load reporting period begins, we are able to count the total requests issued in a load reporting interval. This information is then used to populate the field total_issued_requests. Risk Level: Low Testing: //test/integration:load_stats_reporter passes. Signed-off-by: Karthik Reddy <rekarthik@google.com> Signed-off-by: Jeff Piazza <jeffpiazza@google.com>
jeffpiazza-google
pushed a commit
to jeffpiazza-google/envoy
that referenced
this pull request
May 3, 2019
…int Stats. (envoyproxy#6692)" (envoyproxy#6761) This reverts commit cdddf54. Signed-off-by: Lizan Zhou <lizan@tetrate.io> Signed-off-by: Jeff Piazza <jeffpiazza@google.com>
karthikbox
pushed a commit
to karthikbox/envoy
that referenced
this pull request
May 10, 2019
…d Endpoint Stats. (envoyproxy#6692) Changes: Fixes coverage test hang. No change to core logic from envoyproxy#6692. Signed-off-by: Karthik Reddy <rekarthik@google.com>
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
May 10, 2019
* master: (88 commits) upstream: Null-deref on TCP health checker if setsockopt fails (envoyproxy#6793) ci: switch macOS CI to azure pipelines (envoyproxy#6889) os syscalls lib: break apart syscalls used for hot restart (envoyproxy#6880) Kafka codec: precompute request size before serialization, so we do n… (envoyproxy#6862) upstream: move static and strict_dns clusters to dedicated files (envoyproxy#6886) Rollforward of api: Add total_issued_requests to Upstream Locality and Endpoint Stats. (envoyproxy#6692) (envoyproxy#6784) fix explicit constructor in copy-initialization (envoyproxy#6884) stats: use tag iterator rather than constructing the tag-array and searching that. (envoyproxy#6853) common: use unscoped build target in generate_version_linkstamp (envoyproxy#6877) Addendum to envoyproxy#6778 (envoyproxy#6882) ci: add minimum Linux build for Azure Pipelines (envoyproxy#6881) grpc: utilities for inter-converting grpc::ByteBuffer and Buffer::Instance. (envoyproxy#6732) upstream: allow excluding hosts from lb calculations until initial health check (envoyproxy#6794) stats: prevent unused counters from leaking across hot restart (envoyproxy#6850) network filters: add `injectDataToFilterChain(data, end_stream)` method to network filter callbacks (envoyproxy#6750) delete things that snuck back in (envoyproxy#6873) config: scoped rds (2b): support delta APIs in ConfigProvider framework (envoyproxy#6781) string == string! (envoyproxy#6868) config: add mssing imports to delta_subscription_state (envoyproxy#6869) protobuf: add missing default case to enum (envoyproxy#6870) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
total_issued_requests field tracks the count of requests issued since
the last report. This field will be used for global load balancing
decisions.
Envoy maintains a stats counter rq_total to track total
requests made. By latching this counter when load reporting period
begins, we are able to count the total requests issued in a load
reporting interval. This information is then used to populate the field
total_issued_requests.
Risk Level: Low
Testing: //test/integration:load_stats_reporter passes.