Skip to content

tools/examples: remove v1_to_bootstrap and v1 example configs#6556

Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
derekargueta:dereka/remove-v1-to-bootstrap
Apr 11, 2019
Merged

tools/examples: remove v1_to_bootstrap and v1 example configs#6556
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
derekargueta:dereka/remove-v1-to-bootstrap

Conversation

@derekargueta
Copy link
Member

Description: v1_to_boostrap.cc is a utility that, as named, converts v1 configurations into a v2 configuration. The v1 API support has been removed since 1.8 so I think it's safe to remove this tool. I've also removed the example google v1 configurations, as at this point they may just cause confusion rather than aid newcomers. Since it's not part of the runtime and given the long deprecation period, I think deletion is fine.
Risk Level: none - proxy code is untouched
Testing: n/a
Docs Changes: updated to remove mention of v1_to_bootstrap tool
Release Notes: n/a

Signed-off-by: Derek Argueta dereka@pinterest.com

Signed-off-by: Derek Argueta <dereka@pinterest.com>
@derekargueta
Copy link
Member Author

coverage output:

WARNING: Running Bazel server needs to be killed, because the startup options are different.
WARNING: Waiting for server process to terminate (waited 5 seconds, waiting at most 60)
WARNING: Waiting for server process to terminate (waited 10 seconds, waiting at most 60)
WARNING: Waiting for server process to terminate (waited 30 seconds, waiting at most 60)
INFO: Waited 60 seconds for server process (pid=82) to terminate.
WARNING: Waiting for server process to terminate (waited 5 seconds, waiting at most 10)
WARNING: Waiting for server process to terminate (waited 10 seconds, waiting at most 10)
INFO: Waited 10 seconds for server process (pid=82) to terminate.
FATAL: Attempted to kill stale server process (pid=82) using SIGKILL, but it did not die in a timely fashion.

Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
@moderation
Copy link
Contributor

Thanks for this PR. When I updated the docs and configs previously in #6025 and #6368 I studiously avoided the v1 to v2 stuff. Good to remove it.

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@mattklein123 mattklein123 merged commit d68eb4c into envoyproxy:master Apr 11, 2019
@derekargueta derekargueta deleted the dereka/remove-v1-to-bootstrap branch June 28, 2019 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants