Skip to content

Docs: Update reference configurations YAML templates for Struct deprecation for Any and hosts deprecation for load_assignment#6368

Merged
htuch merged 11 commits intoenvoyproxy:masterfrom
moderation:master
Mar 27, 2019
Merged

Docs: Update reference configurations YAML templates for Struct deprecation for Any and hosts deprecation for load_assignment#6368
htuch merged 11 commits intoenvoyproxy:masterfrom
moderation:master

Conversation

@moderation
Copy link
Contributor

@moderation moderation commented Mar 23, 2019

Description: Update examples for Struct deprecation for Any
Risk Level: Low - generated configs only, no changes to code
Testing: bazel build //configs:example_configs, bazel test //test/...
Docs Changes: None required
Release Notes: None required
Completes: #6025
Replaces: #6356
Related: #6346

@moderation
Docs and sandboxes: Remove reference to Docker Machine, fix sandbox c…
b0d6eab 
…onfigs, updates Sandbox docs.

Signed-off-by: Michael Payne <michael@sooper.org>
@moderation
Standardize on pulling fresh images before launching containers.
89bab5a 
Signed-off-by: Michael Payne <michael@sooper.org>
@moderation
Explicitly add DNS for Docker containers for edge case where host mac…
02ad9d2 
…hine running DoH / DoT - enable successful download of libjaegertracing_plugin.linux_amd64.so for jaeger-native-tracing sandbox.

Signed-off-by: Michael Payne <michael@sooper.org>
@moderation
Standardize on upcase E for Envoy in the docs.
c132c98 
Signed-off-by: Michael Payne <michael@sooper.org>
@moderation
Text formatting fixes.
f43b900 
Signed-off-by: Michael Payne <michael@sooper.org>
@moderation
Merge remote-tracking branch 'upstream/master'
1d15d33
@moderation
Merge remote-tracking branch 'upstream/master'
86a1615
@moderation
Merge remote-tracking branch 'upstream/master'
58a19fb
@moderation
Docs: Update examples for Struct deprecation for Any
2e0627b 
Signed-off-by: Michael Payne <michael@sooper.org>
@moderation
Copy link
Contributor Author

moderation commented Mar 23, 2019 •
edited
Loading

Ready for review @dio. This ended up being a fairly big change @derekargueta - thanks for starting the load_assignment change.

@lizan lizan requested a review from dio March 25, 2019 18:22
@lizan lizan self-assigned this Mar 25, 2019
@lizan lizan requested a review from htuch March 25, 2019 18:22
htuch
htuch suggested changes Mar 25, 2019
View reviewed changes
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a nice contribution to moving forward on Any as production support (modulo the hashing issues). Looks mostly good.. have you tested the resulting YAML from the templates anywhere? Just loading them up into an Envoy would be good (not sure if the tests you have in the commit message do this).

/wait

@moderation moderation changed the title Docs: Update examples for Struct deprecation for Any Docs: Update examples for Struct deprecation for Any and hosts deprecation for load_assignment Mar 26, 2019
@moderation
Copy link
Contributor Author

moderation commented Mar 26, 2019

@htuch The resulting YAML is tested with bazel test //test/... and it has been a painstaking process to run all the changes through to eliminate all the issues when working through the changes. Further than that I did run all of the generated config files in generated/configs/ to make sure they loaded into Envoy. This combined with passing tests should be OK.

@moderation moderation changed the title Docs: Update examples for Struct deprecation for Any and hosts deprecation for load_assignment Docs: Update reference configurations YAML templates for Struct deprecation for Any and hosts deprecation for load_assignment Mar 26, 2019
@moderation
Copy link
Contributor Author

moderation commented Mar 26, 2019

The documentation doesn't change in this PR but the referring section in the docs to the Reference configurations is at https://www.envoyproxy.io/docs/envoy/latest/install/ref_configs

dio
dio reviewed Mar 26, 2019
View reviewed changes
configs/envoy_front_proxy_v2.template.yaml Outdated
- name: envoy.http_connection_manager
config:
typed_config:
'@type': type.googleapis.com/envoy.config.filter.network.http_connection_manager.v2.HttpConnectionManager
Copy link
Member

@dio dio Mar 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nit, not sure if we should always use " instead of ' for this.

Copy link
Contributor Author

@moderation moderation Mar 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixing now.

@moderation
Standardize on double quote for @type declarations.
9a8cc18 
Signed-off-by: Michael Payne <michael@sooper.org>
htuch
htuch approved these changes Mar 27, 2019
View reviewed changes
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@htuch htuch merged commit fc5a3b2 into envoyproxy:master Mar 27, 2019
@moderation moderation mentioned this pull request Apr 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@dio dio dio left review comments

@htuch htuch htuch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lizan lizan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@moderation @dio @htuch @lizan