test: Ensure only one thread advances time, and enable simulated-time for hds_integration_test.#6541
Merged
lizan merged 6 commits intoenvoyproxy:masterfrom Apr 13, 2019
Merged
Conversation
…ds_integration_test. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
It's possible this may fix #5183 as well. |
…s, and add more info to an address-conflict issue in an unrelated flake. Signed-off-by: Joshua Marantz <jmarantz@google.com>
…d method. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
/retest |
|
🔨 rebuilding |
lizan
reviewed
Apr 12, 2019
…y_for_test.*. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
lizan
approved these changes
Apr 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: It is hard to reason about tests that push time forward from more than one thread. This was happening in contention-tests. This adds some asserts to ensure that we don't do this in future tests, and fixes those tests that were doing it.
Risk Level: low
Testing: //test/..., and hds_integration_test witih tsan and --runs_per_test=1000
Docs Changes: n/a
Release Notes: n/a
Fixes: #6239