Only generate a descriptor if all actions append an entry.#632
Merged
Only generate a descriptor if all actions append an entry.#632
Conversation
| be processed. For example given the following rate limit configuration, a request can | ||
| generate a few possible descriptors depending on what is present in the request. | ||
| If an action doesn't append a descriptor entry, no descriptor is generated for the configuration. | ||
| For example given the following rate limit configuration, there are two possible outcomes: |
Member
There was a problem hiding this comment.
Can you rephrase slightly. You don't actually show a second outcome. I would just move the clause after into this sentence, and show what gets output if a descriptor is output at all.
Also, this is from previous commit, but for the fixed with descriptor examples, it's a little strange to split the entries across multiple lines. If you want to line split, can you split on an entry basis and align the opening parenthesis. (Same elsewhere in this file).
| * @param local_service_cluster supplies the name of the local service cluster. | ||
| * @param headers supplies the header for the request. | ||
| * @param remote_address supplies the trusted downstream address for the connection. | ||
| * @return true if the RateLimitAction populated the descriptor. Otherwise, false is returned. |
Member
There was a problem hiding this comment.
Del "Otherwise, false is returned." (Obvious)
mattklein123
approved these changes
Mar 28, 2017
jplevyak
added a commit
to jplevyak/envoy
that referenced
this pull request
Sep 9, 2020
…-upstream-wasm Import envoyproxy and upstream wasm
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** This removes the inference extension related code from the controller to reduce the size of the refactoring PR #629. We need to do the complete redo on inference extension after #629, so this doesn't mean that we drop the support for it. --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When processing a rate limit configuration, all actions are to append a descriptor entry. If an action can't append an entry, there is no descriptor generated for the configuration.