test: add ability to call external additional setup script#629
Merged
mattklein123 merged 1 commit intomasterfrom Mar 26, 2017
Merged
test: add ability to call external additional setup script#629mattklein123 merged 1 commit intomasterfrom
mattklein123 merged 1 commit intomasterfrom
Conversation
Member
Author
|
@htuch trying to get my script to run first was kind of a mess. I think this is a better solution. We should be able to do something similar in bazel I would imagine. |
Member
|
LGTM. We can sync soon to discuss the additional test environment you have and how to do in Bazel. As a status update, I should have the base Bazel BUILD files for test + main binary done today, next week will be filling in the edges (e.g. developer and user docs, handling tcmalloc, profiler, Docker CI, sanitizers, etc.). We should be ready to contemplate turning Bazel on for CI and deprecating cmake in 0.5 week. |
jplevyak
pushed a commit
to jplevyak/envoy
that referenced
this pull request
Aug 28, 2020
tests: add coverage for wasm state and foreign
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** This removes the inference extension related code from the controller to reduce the size of the refactoring PR #629. We need to do the complete redo on inference extension after #629, so this doesn't mean that we drop the support for it. --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** This commit refactors the internal on how the ext proc is deployed. Specifically, this switches to insert the ext proc container as a sidecar container of Envoy pods created by Envoy Gateway. This is another large refactoring that turned out necessary for #599. This utilizes the mutating webhook to insert the extproc container Envoy pods. Making the extproc as as sidecar means that we now have a one-to-one mapping between Gateway and the extproc hence this naturally resolves the previously known limitation #509 and now users can attach multiple AIGatewayRoute(s) to one Gateway. Implementation note: since the volume mounts only work in the namespace-scoped way, use-created secrets (like API Keys) cannot be mounted by the extproc as it runs in "envoy-gateway-system" namespace. To resolve this, now the controller reads the secret and embed the read credentials into the "extproc secret" (which is previously known as "extproc configmap") together with routing, matching and backend information. That secret is written in the "envoy-gateway-system" namespace hence it can be mounted by the extproc container. **Related Issues/PRs (if applicable)** Resolves #509 Resolves #621 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.