Wire up panic mode subset to receive updates#6221
Merged
htuch merged 5 commits intoenvoyproxy:masterfrom Mar 12, 2019
Merged
Conversation
The initial diff missed handling added/removed hosts, this handles that. Reported-by: @nezdolik Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
To make things more consistent between the fallback and the panic subset, create both at construction time. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
nezdolik
reviewed
Mar 10, 2019
| @@ -186,34 +205,18 @@ SubsetLoadBalancer::LbSubsetEntryPtr SubsetLoadBalancer::findSubset( | |||
|
|
|||
| void SubsetLoadBalancer::updateFallbackSubset(uint32_t priority, const HostVector& hosts_added, | |||
Member
There was a problem hiding this comment.
update name? as this method now updates not only default subset
Member
Author
There was a problem hiding this comment.
hmm the panic mode subset is tied to the fallback subset.. not sure what a better name would be.
nezdolik
reviewed
Mar 10, 2019
| scale_locality_weight_(subsets.scaleLocalityWeight()) { | ||
| ASSERT(subsets.isEnabled()); | ||
|
|
||
| if (fallback_policy_ != envoy::api::v2::Cluster::LbSubsetConfig::NO_FALLBACK) { |
Member
There was a problem hiding this comment.
could be just a personal preference, but would rather use deferred initialisation or private helper method not to make constructor code blow up
htuch
previously approved these changes
Mar 11, 2019
source/common/upstream/subset_lb.cc
Outdated
|
|
||
| ENVOY_LOG(debug, "subset lb: creating any-endpoint fallback load balancer"); | ||
| } else { | ||
| predicate = std::bind(&SubsetLoadBalancer::hostMatches, this, default_subset_metadata_, |
Member
There was a problem hiding this comment.
Nit: I think a lambda might be clearer here.
Switch to lambda in an unrelated spot too, but it's indirectly related so might as well be consistent. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
added 2 commits
March 11, 2019 11:59
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
spenceral
added a commit
to spenceral/envoy
that referenced
this pull request
Mar 20, 2019
* master: (59 commits) http fault: add response rate limit injection (envoyproxy#6267) xds: introduce initial_fetch_timeout option to limit initialization time (envoyproxy#6048) test: fix cpuset-threads tests (envoyproxy#6278) server: add an API for registering for notifications for server instance life… (envoyproxy#6254) remove remains of TestBase (envoyproxy#6286) dubbo_proxy: Implement the routing of Dubbo requests (envoyproxy#5973) Revert "stats: add new BoolIndicator stat type (envoyproxy#5813)" (envoyproxy#6280) runtime: codifying runtime guarded features (envoyproxy#6134) mysql_filter: fix integration test flakes (envoyproxy#6272) tls: update BoringSSL to debed9a4 (3683). (envoyproxy#6273) rewrite buffer implementation to eliminate evbuffer dependency (envoyproxy#5441) Remove the dependency from TimeSystem to libevent by using the Event::Scheduler abstraction as a delegate. (envoyproxy#6240) fuzz: fix use of literal in default initialization. (envoyproxy#6268) http: add HCM functionality required for rate limiting (envoyproxy#6242) Disable mysql_integration_test until it is deflaked. (envoyproxy#6250) test: use ipv6_only IPv6 addresses in custom cluster integration tests. (envoyproxy#6260) tracing: If parent span is propagated with empty string, it causes th… (envoyproxy#6263) upstream: fix oss-fuzz issue envoyproxy#11095. (envoyproxy#6220) Wire up panic mode subset to receive updates (envoyproxy#6221) docs: clarify xds docs with warming information (envoyproxy#6236) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial diff missed handling added/removed hosts, this
handles that.
While at this, lets move the fallback subset creation to the constructor
so that it's consistent with the panic mode subset.
Reported-by: @nezdolik
Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com