upstream: fix oss-fuzz issue #11095.#6220
Merged
htuch merged 5 commits intoenvoyproxy:masterfrom Mar 12, 2019
Merged
Conversation
Do not attempt to read IP address information from a unix domain socket address. Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com>
Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com>
Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com>
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Instead of silently dropping the port, should this actually be a config error and throw an exception? It seems like busted config to me? WDYT?
Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com>
Member
Author
|
Makes sense. I added a patch which does that. |
htuch
reviewed
Mar 11, 2019
| // Setting the health check port to non-0 only works for IP-type addresses. Setting the port | ||
| // for a pipe address is a misconfiguration. Throw an exception. | ||
| throw EnvoyException( | ||
| fmt::format("Invalid host configuration: non-null port for non-IP address")); |
Member
Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com>
ipuustin
force-pushed
the
oss-fuzz-11095
branch
from
c01d1fd to
c7d08b6
Compare
Member
Author
|
/retest |
|
🔨 rebuilding |
Member
Author
|
@htuch Sure, I can help with them. There's also still a bunch of already open ones in the fuzzer backlog. |
spenceral
added a commit
to spenceral/envoy
that referenced
this pull request
Mar 20, 2019
* master: (59 commits) http fault: add response rate limit injection (envoyproxy#6267) xds: introduce initial_fetch_timeout option to limit initialization time (envoyproxy#6048) test: fix cpuset-threads tests (envoyproxy#6278) server: add an API for registering for notifications for server instance life… (envoyproxy#6254) remove remains of TestBase (envoyproxy#6286) dubbo_proxy: Implement the routing of Dubbo requests (envoyproxy#5973) Revert "stats: add new BoolIndicator stat type (envoyproxy#5813)" (envoyproxy#6280) runtime: codifying runtime guarded features (envoyproxy#6134) mysql_filter: fix integration test flakes (envoyproxy#6272) tls: update BoringSSL to debed9a4 (3683). (envoyproxy#6273) rewrite buffer implementation to eliminate evbuffer dependency (envoyproxy#5441) Remove the dependency from TimeSystem to libevent by using the Event::Scheduler abstraction as a delegate. (envoyproxy#6240) fuzz: fix use of literal in default initialization. (envoyproxy#6268) http: add HCM functionality required for rate limiting (envoyproxy#6242) Disable mysql_integration_test until it is deflaked. (envoyproxy#6250) test: use ipv6_only IPv6 addresses in custom cluster integration tests. (envoyproxy#6260) tracing: If parent span is propagated with empty string, it causes th… (envoyproxy#6263) upstream: fix oss-fuzz issue envoyproxy#11095. (envoyproxy#6220) Wire up panic mode subset to receive updates (envoyproxy#6221) docs: clarify xds docs with warming information (envoyproxy#6236) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix a crash found by oss-fuzz (see https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11095). The bug is caused by trying to request IP information from a unix domain socket address.
Risk Level: low
Testing: local fuzzing and a regression test for
HostDescriptionImplconstructor