test: add createApiForTest variant that doesnt require making a stats store.#5900
Merged
jmarantz merged 4 commits intoenvoyproxy:masterfrom Feb 11, 2019
Merged
Conversation
…wise used. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
this in places where the test doesn't do anything else with stats. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
/retest |
|
🔨 rebuilding |
Contributor
Author
|
/retest |
|
🔨 rebuilding |
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
… store. (envoyproxy#5900) Signed-off-by: Joshua Marantz <jmarantz@google.com> * Add a way to create test APIs without specifying stats_store, and use this in places where the test doesn't do anything else with stats. Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Many tests don't do anything with stats, but they have to create an IsolatedStatsStore. This just adds an entry-point to create a simple API without a stats-store. Switch tests to use this variant that don't otherwise do anything with stats.
Risk Level: low
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a