Skip to content

tools: fix compilation db generation for VSCode. #5873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lizan merged 1 commit into from
Feb 8, 2019
Merged

tools: fix compilation db generation for VSCode. #5873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions tools/gen_compilation_database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,19 @@ def isCompileTarget(target, args):
return True


def modifyCompileCommand(target):
cxx, options = target["command"].split(" ", 1)
def modifyCompileCommand(target, args):
_, options = target["command"].split(" ", 1)

# Workaround for bazel added C++11 options, those doesn't affect build itself but
# clang-tidy will misinterpret them.
options = options.replace("-std=c++0x ", "")
options = options.replace("-std=c++11 ", "")

if args.vscode:
# Visual Studio Code doesn't seem to like "-iquote". Replace it with
# old-style "-I".
options = options.replace("-iquote ", "-I ")

if isHeader(target["file"]):
options += " -Wno-pragma-once-outside-header -Wno-unused-const-variable"
options += " -Wno-unused-function"
Expand All @@ -58,7 +63,7 @@ def fixCompilationDatabase(args):
with open("compile_commands.json", "r") as db_file:
db = json.load(db_file)

db = [modifyCompileCommand(target) for target in db if isCompileTarget(target, args)]
db = [modifyCompileCommand(target, args) for target in db if isCompileTarget(target, args)]

# Remove to avoid writing into symlink
os.remove("compile_commands.json")
Expand All @@ -72,6 +77,7 @@ def fixCompilationDatabase(args):
parser.add_argument('--include_external', action='store_true')
parser.add_argument('--include_genfiles', action='store_true')
parser.add_argument('--include_headers', action='store_true')
parser.add_argument('--vscode', action='store_true')
parser.add_argument(
'bazel_targets', nargs='*', default=["//source/...", "//test/...", "//tools/..."])
args = parser.parse_args()
Expand Down