tools: fix compilation db generation for VSCode.#5873
Merged
lizan merged 1 commit intoenvoyproxy:masterfrom Feb 8, 2019
Merged
tools: fix compilation db generation for VSCode.#5873lizan merged 1 commit intoenvoyproxy:masterfrom
lizan merged 1 commit intoenvoyproxy:masterfrom
Conversation
Change the gen_compilation_database.py command to accept a --vscode flag. If this flag is on, create such a compilation database which can be used by Visual Studio Code for code analysis. At the moment it only changes "-iquote" compiler options to old-style "-I" options to prevent Visual Studio Code from falling back to tag parser mode. Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com>
lizan
approved these changes
Feb 8, 2019
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Change the gen_compilation_database.py command to accept a --vscode flag. If this flag is on, create such a compilation database which can be used by Visual Studio Code for code analysis. At the moment it only changes "-iquote" compiler options to old-style "-I" options to prevent Visual Studio Code from falling back to tag parser mode. *Risk Level*: low *Testing*: Visual Studio Code v1.31 *Docs Changes*: N/A *Release Notes*: N/A Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Change
gen_compilation_database.pycommand to accept a--vscodeflag. If this flag is on, create such a compilation database which can be used by Visual Studio Code for code analysis. At the moment it only changes-iquotecompiler options to old-style-Ioptions to prevent Visual Studio Code from falling back to tag parser mode.This fix doesn't completely solve all problems VSCode has with Envoy compilation db, but it makes the "Intellisense" functionality work. Note that you need to also compile Envoy to get access to the generated protobuf files.
Risk Level: low
Testing: Visual Studio Code v1.31
Docs Changes: N/A
Release Notes: N/A