maglev: fix handling of unspecified locality weights.#5863
Merged
htuch merged 2 commits intoenvoyproxy:masterfrom Feb 6, 2019
Merged
maglev: fix handling of unspecified locality weights.#5863htuch merged 2 commits intoenvoyproxy:masterfrom
htuch merged 2 commits intoenvoyproxy:masterfrom
Conversation
The config fuzzer showed that the locality weight assertion in envoyproxy#5831 was too strong. Extant behavior was and is that if locality weight is not specified and locality LB weighting, we should just ignore the locality. Fixes oss-fuzz issue https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12923. Risk level: Low Testing: Corpus entry and unit test added. Signed-off-by: Harvey Tuch <htuch@google.com>
| const uint32_t weight = effective_weight(host->weight(), i); | ||
| // If weight is zero, it should be totally excluded from table building | ||
| // below. | ||
| if (weight > 0) { |
There was a problem hiding this comment.
nit: could write (weight != 0), because we're unsigned.
Signed-off-by: Harvey Tuch <htuch@google.com>
snowp
approved these changes
Feb 6, 2019
Contributor
snowp
left a comment
snowp
left a comment
There was a problem hiding this comment.
LGTM - matches how we handle zero locality weight elsewhere.
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
The config fuzzer showed that the locality weight assertion in envoyproxy#5831 was too strong. Extant behavior was and is that if locality weight is not specified and locality LB weighting, we should just ignore the locality. Fixes oss-fuzz issue https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12923. Risk level: Low Testing: Corpus entry and unit test added. Signed-off-by: Harvey Tuch <htuch@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The config fuzzer showed that the locality weight assertion in
#5831 was too strong. Extant behavior was and is that if
locality weight is not specified and locality LB weighting, we should just ignore the locality.
Fixes oss-fuzz issue https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12923.
Risk level: Low
Testing: Corpus entry and unit test added.
Signed-off-by: Harvey Tuch htuch@google.com