upstream: host weight ranges from 1 to 128#5831
Merged
htuch merged 5 commits intoenvoyproxy:masterfrom Feb 5, 2019
mergeconflict:host_weight_range
Merged
upstream: host weight ranges from 1 to 128#5831htuch merged 5 commits intoenvoyproxy:masterfrom mergeconflict:host_weight_range
htuch merged 5 commits intoenvoyproxy:masterfrom
mergeconflict:host_weight_range
Conversation
Signed-off-by: Dan Rosen <mergeconflict@google.com>
Author
|
/review htuch |
Member
|
Please merge master to pick up #5827. |
added 4 commits
February 4, 2019 16:17
…_range Signed-off-by: Dan Rosen <mergeconflict@google.com>
Signed-off-by: Dan Rosen <mergeconflict@google.com>
Signed-off-by: Dan Rosen <mergeconflict@google.com>
…_range Signed-off-by: Dan Rosen <mergeconflict@google.com>
htuch
added a commit
to htuch/envoy
that referenced
this pull request
Feb 6, 2019
The config fuzzer showed that the locality weight assertion in envoyproxy#5831 was too strong. Extant behavior was and is that if locality weight is not specified and locality LB weighting, we should just ignore the locality. Fixes oss-fuzz issue https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12923. Risk level: Low Testing: Corpus entry and unit test added. Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
added a commit
that referenced
this pull request
Feb 6, 2019
The config fuzzer showed that the locality weight assertion in #5831 was too strong. Extant behavior was and is that if locality weight is not specified and locality LB weighting, we should just ignore the locality. Fixes oss-fuzz issue https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12923. Risk level: Low Testing: Corpus entry and unit test added. Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
pushed a commit
to envoyproxy/data-plane-api
that referenced
this pull request
Feb 7, 2019
The config fuzzer showed that the locality weight assertion in envoyproxy/envoy#5831 was too strong. Extant behavior was and is that if locality weight is not specified and locality LB weighting, we should just ignore the locality. Fixes oss-fuzz issue https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12923. Risk level: Low Testing: Corpus entry and unit test added. Signed-off-by: Harvey Tuch <htuch@google.com> Mirrored from https://github.com/envoyproxy/envoy @ 5fd128d63810919840917bdf7da2d018edc5e32f
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Fix some incorrect comments about the range of valid host weights, and updated Maglev LB implementation to assume weights are always non-zero. Risk Level: Low Testing: Existing tests, including maglev_lb_test and upstream_impl_test. Signed-off-by: Dan Rosen <mergeconflict@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
The config fuzzer showed that the locality weight assertion in envoyproxy#5831 was too strong. Extant behavior was and is that if locality weight is not specified and locality LB weighting, we should just ignore the locality. Fixes oss-fuzz issue https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12923. Risk level: Low Testing: Corpus entry and unit test added. Signed-off-by: Harvey Tuch <htuch@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Fix some incorrect comments about the range of valid host weights, and updated Maglev LB implementation to assume weights are always non-zero.
Risk Level: Low
Testing: Existing tests, including maglev_lb_test and upstream_impl_test.
Docs Changes: n/a
Release Notes: n/a
Signed-off-by: Dan Rosen mergeconflict@google.com