build: add pedantic spell check to build

.circleci/config.yml

@@ -4,7 +4,7 @@ executors:
   ubuntu-build:
     description: "A regular build executor based on ubuntu image"
     docker:
-      - image: envoyproxy/envoy-build:111781fa2823535762e9c514db0c5c41a119b4b1
+      - image: envoyproxy/envoy-build:698009170e362f9ca0594f2b1927fbbee199bf98
     resource_class: xlarge
     working_directory: /source
 
@@ -127,6 +127,7 @@ jobs:
        - run: ci/do_circle_ci.sh check_format
        - run: ci/do_circle_ci.sh check_repositories
        - run: ci/do_circle_ci.sh check_spelling
+       - run: ci/do_circle_ci.sh check_spelling_pedantic
    build_image:
      docker:
        - image: circleci/python:3.7

ci/do_ci.sh

@@ -7,7 +7,7 @@ set -e
 build_setup_args=""
 if [[ "$1" == "fix_format" || "$1" == "check_format" || "$1" == "check_repositories" || \
         "$1" == "check_spelling" || "$1" == "fix_spelling" || "$1" == "bazel.clang_tidy" || \
-        "$1" == "check_spelling_pedantic" ]]; then
+        "$1" == "check_spelling_pedantic" || "$1" == "fix_spelling_pedantic" ]]; then
   build_setup_args="-nofetch"
 fi
 
@@ -305,6 +305,11 @@ elif [[ "$1" == "check_spelling_pedantic" ]]; then
   echo "check_spelling_pedantic..."
   ./tools/check_spelling_pedantic.py check
   exit 0
+elif [[ "$1" == "fix_spelling_pedantic" ]]; then
+  cd "${ENVOY_SRCDIR}"
+  echo "fix_spelling_pedantic..."
+  ./tools/check_spelling_pedantic.py fix
+  exit 0
 elif [[ "$1" == "docs" ]]; then
   echo "generating docs..."
   docs/build.sh

include/envoy/stats/symbol_table.h

@@ -87,7 +87,7 @@ class SymbolTable {
    * with a corrupt stats set.
    *
    * @param stat_name the stat name.
-   * @return std::string stringifiied stat_name.
+   * @return std::string stringified stat_name.
    */
   virtual std::string toString(const StatName& stat_name) const PURE;
 
@@ -122,7 +122,7 @@ class SymbolTable {
    *
    * This is intended for use doing cached name lookups of scoped stats, where
    * the scope prefix and the names to combine it with are already in StatName
-   * form. Using this class, they can be combined without acessingm the
+   * form. Using this class, they can be combined without accessing the
    * SymbolTable or, in particular, taking its lock.
    *
    * @param stat_names the names to join.

test/common/network/udp_listener_impl_test.cc

@@ -256,7 +256,7 @@ TEST_P(ListenerImplTest, UdpEcho) {
   getSocketAddressInfo(*client_socket.get(), server_ip->port(), server_addr, addr_len);
   ASSERT_GT(addr_len, 0);
 
-  // We send 2 packets and exptect it to echo.
+  // We send 2 packets and expect it to echo.
   const std::string first("first");
   const std::string second("second");
 
@@ -456,7 +456,7 @@ TEST_P(ListenerImplTest, UdpListenerEnableDisable) {
 }
 
 /**
- * Tests UDP listebe's error callback.
+ * Tests UDP listener's error callback.
  */
 TEST_P(ListenerImplTest, UdpListenerRecvFromError) {
   // Setup server socket

tools/check_format.py

@@ -16,7 +16,7 @@
 
 EXCLUDED_PREFIXES = ("./generated/", "./thirdparty/", "./build", "./.git/", "./bazel-", "./.cache",
                      "./source/extensions/extensions_build_config.bzl",
-                     "./tools/testdata/check_format/")
+                     "./tools/testdata/check_format/", "./tools/pyformat/")
 SUFFIXES = (".cc", ".h", "BUILD", "WORKSPACE", ".bzl", ".md", ".rst", ".proto")
 DOCS_SUFFIX = (".md", ".rst")
 PROTO_SUFFIX = (".proto")