build: add pedantic spell check to build#5779
Merged
mattklein123 merged 10 commits intoenvoyproxy:masterfrom Feb 1, 2019
Merged
build: add pedantic spell check to build#5779mattklein123 merged 10 commits intoenvoyproxy:masterfrom
mattklein123 merged 10 commits intoenvoyproxy:masterfrom
Conversation
Adds support for fixing errors via the pedantic spell checker. Runs pedantic comment spelling checking during builds. Adds the location where python deps are installed during do_ci.sh (to avoid spurrious format check errors). *Risk Level*: low *Testing*: checks comment spelling *Docs Changes*: n/a *Release Notes*: n/a Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Member
Author
|
BTW, I expect this to fail the format check because new typos have been introduced since yesterday. I'll fix them once I see the expected failure. |
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Member
Author
|
Seems to be working. This is ready for review. |
Member
Author
|
/retest |
|
🔨 rebuilding |
Member
venilnoronha
left a comment
venilnoronha
left a comment
There was a problem hiding this comment.
This is very useful, thanks!
I've left a few nits. One other nit is about comments in check_spelling_pedantic.py i.e. some start with an uppercase letter while others don't, and similarly an inconsistency in the usage of periods.
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Member
Author
|
/retest |
|
🔨 rebuilding |
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
mattklein123
approved these changes
Feb 1, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Epic! Let's just merge and iterate if we run into issues.
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Adds support for fixing errors via the pedantic spell checker. Runs pedantic comment spelling checking during builds. Adds the location where python deps are installed during do_ci.sh (to avoid spurrious format check errors). *Risk Level*: low *Testing*: checks comment spelling *Docs Changes*: n/a *Release Notes*: n/a Signed-off-by: Stephan Zuercher <zuercher@gmail.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for fixing errors via the pedantic spell checker.
Runs pedantic comment spelling checking during builds.
Adds the location where python deps are installed during
do_ci.sh (to avoid spurious format check errors).
Risk Level: low
Testing: checks comment spelling
Docs Changes: n/a
Release Notes: n/a
Signed-off-by: Stephan Zuercher zuercher@gmail.com