stats: Filter out rejected stats from scope caches when the stat-matcher is applied.#5105
Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom Nov 26, 2018
Merged
Conversation
…applied. Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
requested changes
Nov 26, 2018
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Makes sense to me. Is there any way to have a small test of this behavior in the thread local store tests? I think it shouldn't be too hard?
/wait
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
…her is applied. (envoyproxy#5105) Signed-off-by: Joshua Marantz <jmarantz@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Part of the plan to reduce stats overhead involves pre-allocating them at startup, rather than looking them up in hash-tables in the hot path. This means some of them will be allocated before the stats matcher is applied. #5031 is one example of this. To reduce their overhead and to make the stats-matcher integration test clean, this PR removes rejected stats from the scope cache. We can't delete the stat itself (there will be references to it in various data structures) but we can have it not be queriable via the admin interface.
Risk Level: low
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a