Skip to content

retry plugins: specify the correct config proto for other_priority #4670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alyssawilk merged 4 commits into from
Oct 10, 2018
Merged

retry plugins: specify the correct config proto for other_priority #4670

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fd84606
retry plugins: specify the correct config proto for other_priority
Oct 10, 2018
5126eab
header order
Oct 10, 2018
072e487
kick ci
Oct 10, 2018
b384f49
exercise createEmptyProto in test
Oct 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion source/extensions/retry/priority/other_priority/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#pragma once

#include "envoy/config/retry/other_priority/other_priority_config.pb.validate.h"
#include "envoy/upstream/retry.h"

#include "common/protobuf/protobuf.h"
Expand All @@ -22,7 +23,8 @@ class OtherPriorityRetryPriorityFactory : public Upstream::RetryPriorityFactory
}

ProtobufTypes::MessagePtr createEmptyConfigProto() override {
return ProtobufTypes::MessagePtr(new ::Envoy::ProtobufWkt::Empty());
return ProtobufTypes::MessagePtr(
new envoy::config::retry::other_priority::OtherPriorityConfig());
}
};

Expand Down