retry plugins: specify the correct config proto for other_priority#4670
Merged
alyssawilk merged 4 commits intoenvoyproxy:masterfrom Oct 10, 2018
Merged
retry plugins: specify the correct config proto for other_priority#4670alyssawilk merged 4 commits intoenvoyproxy:masterfrom
alyssawilk merged 4 commits intoenvoyproxy:masterfrom
Conversation
added 3 commits
October 10, 2018 09:48
Previously this was set to Empty, which caused config parsing to fail
with
message=Unable to parse JSON as proto (INVALID_ARGUMENT:: invalid name u
pdate_frequency: Cannot find field.): {"update_frequency":2}
Signed-off-by: Snow Pettersen <snowp@squareup.com>
Signed-off-by: Snow Pettersen <snowp@squareup.com>
alyssawilk
suggested changes
Oct 10, 2018
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
Can we regression test?
Signed-off-by: Snow Pettersen <snowp@squareup.com>
mattklein123
approved these changes
Oct 10, 2018
aa-stripe
pushed a commit
to aa-stripe/envoy
that referenced
this pull request
Oct 11, 2018
…nvoyproxy#4670) Previously this was set to Empty, which caused config parsing to fail with message=Unable to parse JSON as proto (INVALID_ARGUMENT:: invalid name update_frequency: Cannot find field.): {"update_frequency":2} Risk Level: Low Testing: n/a Docs Changes: n/a Signed-off-by: Snow Pettersen <snowp@squareup.com> Signed-off-by: Aaltan Ahmad <aa@stripe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this was set to Empty, which caused config parsing to fail
with
Risk Level: Low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a