syscall: refactor OsSysCalls for deeper errno latching#4111
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Aug 13, 2018
Merged
syscall: refactor OsSysCalls for deeper errno latching#4111mattklein123 merged 3 commits intoenvoyproxy:masterfrom
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
Conversation
* Introduce SysCallIntResult, SysCallSizeResult and SysCallPtrResult * Refactor OsSysCalls routines to return appropriate SysCallResult types Signed-off-by: Venil Noronha <veniln@vmware.com>
venilnoronha
force-pushed
the
gh-3819-fix-syscalls
branch
from
290a106 to
4235c7f
Compare
Signed-off-by: Venil Noronha <veniln@vmware.com>
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, this is a really great change.
| bytes_avail = std::min(size_t(bytes_avail), proxy_protocol_header_.value().extensions_length_); | ||
| ssize_t nread = os_syscalls.recv(fd, buf_, bytes_avail, 0); | ||
| const Api::SysCallSizeResult result = os_syscalls.recv(fd, buf_, bytes_avail, 0); | ||
| ssize_t nread = result.rc_; |
Member
There was a problem hiding this comment.
Do we nee the ssize_t local var here? Same elsewhere in this function? Is a similar simplification available any other places that I didn't notice?
Member
Author
There was a problem hiding this comment.
Thought it'd keep the code more readable. I can simplify it here and at other places if required.
Member
There was a problem hiding this comment.
I would probably drop the local variables where possible, but I don't feel that strongly about it. (I think the code would stay readable as long as the return value variable name is readable).
Member
Author
Signed-off-by: Venil Noronha <veniln@vmware.com>
venilnoronha
force-pushed
the
gh-3819-fix-syscalls
branch
from
6b5e263 to
b372000
Compare
snowp
pushed a commit
to snowp/envoy
that referenced
this pull request
Aug 14, 2018
* origin/master: (38 commits) test: add tests for corner-cases around sending requests before run() starts or after run() ends. (envoyproxy#4114) perf: reduce the memory usage of LC Trie construction (envoyproxy#4117) test: moving redundant code in websocket_integration_test to utilities (envoyproxy#4127) test: make YamlLoadFromStringFail less picky about error msg. (envoyproxy#4141) rbac: add rbac network filter. (envoyproxy#4083) fuzz: route lookup and header finalization fuzzer. (envoyproxy#4116) Set content-type and content-length (envoyproxy#4113) fault: use FractionalPercent for percent (envoyproxy#3978) test: Fix inverted exact match logic in IntegrationTcpClient::waitForData() (envoyproxy#4134) Added cluster_name to load assignment config for static cluster (envoyproxy#4123) ssl: refactor ContextConfig to use TlsCertificateConfig (envoyproxy#4115) syscall: refactor OsSysCalls for deeper errno latching (envoyproxy#4111) thrift_proxy: fix oneway bugs (envoyproxy#4025) Do not crash when converting YAML to JSON fails (envoyproxy#4110) config: allow unknown fields flag (take 2) (envoyproxy#4096) Use a jittered backoff strategy for handling HdsDelegate stream/connection failures (envoyproxy#4108) bazel: use GCS remote cache (envoyproxy#4050) Add thread local cache of overload action states (envoyproxy#4090) Added TCP healthcheck capabilities to the HdsDelegate (envoyproxy#4079) secret: add secret provider interface and use it for TlsCertificates (envoyproxy#4086) ... Signed-off-by: Snow Pettersen <snowp@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR refactors
OsSysCallsfor deepererrnolatching. See #3819 for more information.SysCallIntResult,SysCallSizeResultandSysCallPtrResultOsSysCallsroutines to return appropriateSysCallResulttypesSigned-off-by: Venil Noronha veniln@vmware.com
Risk Level: Low
Testing: Existing tests suffice
Docs Changes: N/A
Release Notes: N/A