Skip to content

Add requestedServerName() to Network::connection #3782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattklein123 merged 4 commits into from
Jul 4, 2018
Merged

Add requestedServerName() to Network::connection #3782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f3d5235
add requestedServerName() to Network::Connection
vadimeisenbergibm Jul 3, 2018
09c6208
add expected_requested_server_name parameter to testUtilV2()
vadimeisenbergibm Jul 3, 2018
af0862b
add SslSocketTest.GetRequestedServerName test
vadimeisenbergibm Jul 3, 2018
c37e852
move expected_requested_server_name before expected_alpn_protocol
vadimeisenbergibm Jul 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions include/envoy/network/connection.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,11 @@ class Connection : public Event::DeferredDeletable, public FilterManager {
*/
virtual const Ssl::Connection* ssl() const PURE;

/**
* @return requested server name (e.g. SNI in TLS), if any.
*/
virtual absl::string_view requestedServerName() const PURE;

/**
* @return State the current state of the connection.
*/
Expand Down
1 change: 1 addition & 0 deletions source/common/network/connection_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ class ConnectionImpl : public virtual Connection,
const ConnectionSocket::OptionsSharedPtr& socketOptions() const override {
return socket_->options();
}
absl::string_view requestedServerName() const override { return socket_->requestedServerName(); }

// Network::BufferSource
BufferSource::StreamBuffer getReadBuffer() override { return {read_buffer_, read_end_stream_}; }
Expand Down
Loading