Add requestedServerName() to Network::connection#3782
Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom Jul 4, 2018
Merged
Conversation
Signed-off-by: Vadim Eisenberg <vadime@il.ibm.com>
Signed-off-by: Vadim Eisenberg <vadime@il.ibm.com>
Signed-off-by: Vadim Eisenberg <vadime@il.ibm.com>
PiotrSikora
previously approved these changes
Jul 3, 2018
Contributor
PiotrSikora
left a comment
PiotrSikora
left a comment
There was a problem hiding this comment.
LGTM, small nit if it's not too much of a nuisance.
cc @ggreenway
test/common/ssl/ssl_socket_test.cc
Outdated
| const std::string& expected_client_cert_uri, | ||
| const std::string& expected_alpn_protocol, | ||
| const std::string& expected_stats, unsigned expected_stats_value, | ||
| const std::string& expected_requested_server_name, |
Contributor
There was a problem hiding this comment.
Nit, but could you move this before expected_alpn_protocol?
Member
|
Waiting to merge until @vadimeisenbergibm pushes the commit mentioned in latest comment |
Signed-off-by: Vadim Eisenberg <vadime@il.ibm.com>
vadimeisenbergibm
dismissed stale reviews from ggreenway and PiotrSikora
via
c37e852
Contributor
Author
|
@PiotrSikora @ggreenway Done, took me some time, sorry. |
mattklein123
approved these changes
Jul 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Add requestedServerName() to Network::connection, to enable using the SNI value in the filters. The current use case is sending the SNI value to the Istio mixer for monitoring and policy enforcement. Suppose we have *.ibm.com value in sni_domains, and a request is sent to www.ibm.com, the requirement is to extract the value of www.ibm.com by a listener and to send it to Mixer.
Risk Level: Low
Testing: Added SslSocketTest.GetRequestedServerName test
Docs Changes: None
Release Notes: None
Is related to issue #3707, is a prerequisite for istio/istio#6810