wasm: re-enable envoy wasm coverage build by disabling rust coverage build #36337
Conversation
Signed-off-by: Boteng Yao <[email protected]>
Signed-off-by: Boteng Yao <[email protected]>
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Signed-off-by: Boteng Yao <[email protected]>
botengyao
changed the title
botengyao
changed the title
|
/retest |
|
/assgin @phlax |
|
/assign @mpwarres |
|
/assgin @phlax |
Signed-off-by: Boteng Yao <[email protected]>
|
CC @envoyproxy/coverage-shephards: FYI only for changes made to |
Signed-off-by: Boteng Yao <[email protected]>
|
the coverage test itself should work but the way to view it from here is not there atm |
|
|
||
| if toolchain.llvm_cov and ctx.configuration.coverage_enabled: | ||
| # https://doc.rust-lang.org/rustc/instrument-coverage.html | ||
| - rustc_flags.add("--codegen=instrument-coverage") |
There was a problem hiding this comment.
Out of curiosity, why does this fix the wasm issue?
There was a problem hiding this comment.
We are compiling rust under wasm-32-unkown-unkown and wasm-wasi targets in our //test repo, but actually instrument-coverage/pgo is not supported for these target envs for rust. Since Envoy at current stage will not profile Rust code, we should be fine to disable it as a whole by default.
repokitteh-read-only
bot
removed
the
deps
I’ve been explored other solutions to #24164 (comment) over the past few days, and here is the final fix, and I think we don't need rust coverage as whole at current stage.
Commit Message: re-enable envoy wasm coverage build by disabling rust coverage build
Additional Description:
Risk Level: no
Fix: #24164
Testing:
Docs Changes: